Skip to content

start to publish releases#35

Merged
j-i-l merged 7 commits intomainfrom
8-package-archive-as-artifact
Mar 20, 2024
Merged

start to publish releases#35
j-i-l merged 7 commits intomainfrom
8-package-archive-as-artifact

Conversation

@j-i-l
Copy link
Copy Markdown
Member

@j-i-l j-i-l commented Mar 20, 2024

This adds an additional workflow that is triggered on a successful run of the CRAN-like checks and only if `github.ref_type == 'tag', i.e. when a new tag is pushed.

It builds the package (just like the Quick build and test actions does and publishes a new release containing the resulting *.tar.gz.

@j-i-l j-i-l linked an issue Mar 20, 2024 that may be closed by this pull request
package archive as artifact #8
Closed
@j-i-l j-i-l self-assigned this Mar 20, 2024
@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Mar 20, 2024

hm, actually, we do not need to condition on the success of the CRAN-like checks as they run on push to main and we have decided to tag manually on main for new releases.
Following this procedure any tagged commit on main will already have passed the CRAN-like checks (or at least they were run for this commit, they might also have failed).

If we want to be super strict we can add on > push > tags to the CRAN-like checks and keep the condition on success for of these tests on the Publish Release.
In doing so we:

  • make an extra run of CRAN-like checks when we push a new tag
  • only create releases for commits that have successfully passed the CRAN-like checks

I'm going for this version for now, we can always relax later

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (efd8daf) to head (2803da2).
Report is 1 commits behind head on main.

❗ Current head 2803da2 differs from pull request most recent head fae2462. Consider uploading reports for the commit fae2462 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files          53       53           
  Lines       10393    10393           
=======================================
  Hits         6889     6889           
  Misses       3504     3504

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Mar 20, 2024

hmm... Publish Release did not run...

@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Mar 20, 2024 •
edited
Loading

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

source

that is likely why.

Will push this to main and make adaptations in a patch

@j-i-l j-i-l marked this pull request as ready for review March 20, 2024 16:24
@j-i-l j-i-l merged commit 20a4e07 into main Mar 20, 2024
j-i-l added a commit that referenced this pull request Mar 20, 2024
@j-i-l
start to publish releases (#35)
59f7ffd 
* start to publish releases

* noT; dev; temp. runc CRAN-like tests on this branch

* now trigger

* run CRAN-like check also on tags

* testing

* bug fix in worklfow

* removing dev edits
@matteodelucchi matteodelucchi deleted the 8-package-archive-as-artifact branch May 22, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@j-i-l j-i-l

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

package archive as artifact

1 participant

@j-i-l