Issue #277 Fix- coursewares chai-jquery test issue#298
Merged
QuincyLarson merged 1 commit intofreeCodeCamp:masterfrom Apr 15, 2015
Merged
Issue #277 Fix- coursewares chai-jquery test issue#298QuincyLarson merged 1 commit intofreeCodeCamp:masterfrom
QuincyLarson merged 1 commit intofreeCodeCamp:masterfrom
Conversation
…t entries for color attrs.
Contributor
|
LGTM |
QuincyLarson
pushed a commit
that referenced
this pull request
Apr 15, 2015
Issue #277 Fix- coursewares chai-jquery test issue
Contributor
|
Thanks, @aldraco! These look good! |
ValeraS
pushed a commit
to ValeraS/freeCodeCamp
that referenced
this pull request
Oct 12, 2018
Add vidoeUrl to responsive web design challenges.
ValeraS
pushed a commit
to ValeraS/freeCodeCamp
that referenced
this pull request
Oct 12, 2018
## [3.2.1](freeCodeCamp/curriculum@v3.2.0...v3.2.1) (2018-09-25) ### Bug Fixes * Add videoUrl field ([freeCodeCamp#298](freeCodeCamp/curriculum#298)) ([ce3cc22](freeCodeCamp/curriculum@ce3cc22))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should address #277 : The tests were not catching correct color attrs for the CSS challenges.
Going forward - reason seems to be that jquery's .css() returns the computed value for colors - i.e. it's running the tests using rgb(255, 0, 0) instead of "red" or hex values. It's also very picky and does want the spaces after the commas - rgb(255,0,0) does not work. (The docs used to say that you can use strings/hex; they have since been corrected.)
http://api.jquery.com/css/#css1
I also changed another test that was looking for "monospace" as the font degradation, but the instructions said to use "Serif." (Specify how fonts should degrade)
I tested them on my computer and they seemed to work just fine.