This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Merged
Conversation
Bouncey
suggested changes
Sep 4, 2018
| "releasedOn": "Feb 17, 2017", | ||
| "challengeType": 0, | ||
| "translations": {}, | ||
| c/Url": "", |
Member
|
@beaucarnes You have some linting errors, also you will need to update the challengeSchema to allow the videoUrl property to be a string, Joi may allow you to check a vaild url also? If it takes more than a minute of looking up I wouldn't worry about it too much. |
Bouncey
suggested changes
Sep 20, 2018
Member
Bouncey
left a comment
There was a problem hiding this comment.
There have been some changes to the schema merged recently, you will need to rebase for those changes.
schema/challengeSchema.js
Outdated
| }) | ||
| ), | ||
| guideUrl: Joi.string().uri({ scheme: 'https' }), | ||
| videoUrl: Joi.string(), |
Member
There was a problem hiding this comment.
To allow for empty strings, this will need to be
Joi.string().allow('')Add vidoeUrl to repsponsive web design challenges. update schema fix schema and capitalization
ab32a2a to
570470d
Compare
raisedadead
approved these changes
Sep 25, 2018
Member
|
Nice work. Thanks @beaucarnes |
raisedadead
pushed a commit
that referenced
this pull request
Sep 25, 2018
## [3.2.1](v3.2.0...v3.2.1) (2018-09-25) ### Bug Fixes * Add videoUrl field ([#298](#298)) ([ce3cc22](ce3cc22))
Member
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add vidoeUrl to responsive web design challenges.