Skip to content

fix(PropertyControl): Allow modelValue as boolean and number as well#485

Merged
surajshetty3416 merged 2 commits intomasterfrom
fix-property-control
Feb 7, 2026
Merged

fix(PropertyControl): Allow modelValue as boolean and number as well#485
surajshetty3416 merged 2 commits intomasterfrom
fix-property-control

Conversation

@surajshetty3416
Copy link
Copy Markdown
Member

@surajshetty3416 surajshetty3416 commented Feb 7, 2026

@surajshetty3416
fix(PropertyControl): Allow modelValue as boolean and number as well
37a92c2 
After #464, property controls stopped accepting values as boolean and number and used to auto convert all values to string, which is why components like TabButton stopped working as expected.
@surajshetty3416
fix(ImageUploadInput): Add fileTypes prop to FileUploader for image u…
d4e5d2c 
…ploads
@surajshetty3416 surajshetty3416 merged commit e8878c8 into master Feb 7, 2026
2 checks passed
@surajshetty3416 surajshetty3416 mentioned this pull request Feb 7, 2026
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2026

🎉 This PR is included in version 1.22.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@surajshetty3416 surajshetty3416 mentioned this pull request Feb 7, 2026
Merged
@surajshetty3416
Copy link
Copy Markdown
Member Author

surajshetty3416 commented Feb 7, 2026

@mergify backport develop

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 7, 2026 •
edited
Loading

backport develop

✅ Backports have been created

Details

Cherry-pick of 37a92c2 has failed:

On branch mergify/bp/develop/pr-485
Your branch is up to date with 'origin/develop'.

You are currently cherry-picking commit 37a92c2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frontend/components.d.ts
	modified:   frontend/src/builder.d.ts
	modified:   frontend/src/components/Controls/AttributePropertyControl.vue
	modified:   frontend/src/components/Controls/StylePropertyControl.vue

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frontend/src/components/Controls/BasePropertyControl.vue
	both modified:   frontend/src/components/Controls/PropertyControlInput.vue
	both modified:   frontend/src/components/Controls/TabButtons.vue

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Feb 7, 2026
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.57%. Comparing base (9beeea5) to head (d4e5d2c).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   52.57%   52.57%           
=======================================
  Files          28       28           
  Lines        2214     2214           
=======================================
  Hits         1164     1164           
  Misses       1050     1050

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

surajshetty3416 added a commit that referenced this pull request Feb 7, 2026
@surajshetty3416
Merge pull request #487 from frappe/mergify/bp/develop/pr-485
ef7bfe2 
fix(PropertyControl): Allow modelValue as boolean and number as well (backport #485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@surajshetty3416