Skip to content

fix(PropertyControl): Allow modelValue as boolean and number as well (backport #485)#487

Merged
surajshetty3416 merged 3 commits intodevelopfrom
mergify/bp/develop/pr-485
Feb 7, 2026
Merged

fix(PropertyControl): Allow modelValue as boolean and number as well (backport #485)#487
surajshetty3416 merged 3 commits intodevelopfrom
mergify/bp/develop/pr-485

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Feb 7, 2026

After #464, property controls stopped accepting values as boolean and number and used to auto convert all values to string, which is why components like TabButton stopped working as expected.

(cherry picked from commit 37a92c2)

# Conflicts:
#	frontend/src/components/Controls/BasePropertyControl.vue
#	frontend/src/components/Controls/PropertyControlInput.vue
#	frontend/src/components/Controls/TabButtons.vue
@surajshetty3416 surajshetty3416 force-pushed the mergify/bp/develop/pr-485 branch from 0e387d8 to dfffc2a Compare February 7, 2026 12:52
@surajshetty3416 surajshetty3416 merged commit ef7bfe2 into develop Feb 7, 2026
3 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.61%. Comparing base (fa1926c) to head (dfffc2a).
⚠️ Report is 145 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #487   +/-   ##
========================================
  Coverage    60.61%   60.61%           
========================================
  Files           28       28           
  Lines         2722     2722           
========================================
  Hits          1650     1650           
  Misses        1072     1072           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant