Skip to content

update 12/4#7

Merged
franklin-feingold merged 65 commits intofranklin-feingold:masterfrom
bids-standard:master
Dec 5, 2018
Merged

update 12/4#7
franklin-feingold merged 65 commits intofranklin-feingold:masterfrom
bids-standard:master

Conversation

@franklin-feingold
Copy link
Copy Markdown
Owner

No description provided.

dasturge and others added 30 commits October 26, 2018 16:02
added contrast enhanced as optional custom label for task fmri
added contrast enhanced as optional custom label for pepolar field maps
Small typo in "scanning sequence" DICOM tag
[MRG] unicode: replace greek mu and omega by micro and ohm signs
Add BIDS extension proposal for PET derivatives and CT scan in 01-introduction.md
Add extension proposal in 01-introduction.md
put links and some text into README
See #47 for initial
brief discussion.

This commit also demonstrates ability to reference other sections within the
document (when referencing fmap Case 4 where _dir described in greater detail
ATM
IMHO there is not need to capitalize it in the text.  Moreover it was
inconsistent - some places had it capitalized and some not
…- implied

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'ses-<session_label>' 'ses-<label>'",
 "exit": 0,
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
…label> -- implied (and inconsistent)

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'sub-<participant_label>' 'sub-<label>'",
 "exit": 0,
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
…lied

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'task-<task_label>' 'task-<label>'",
 "exit": 0,
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'run-<run_index>' 'run-<index>'",
 "exit": 0,
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'dir-<dir_label>' 'dir-<label>'",
 "exit": 0,
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Hboni and others added 28 commits November 22, 2018 23:20
Change BEP numbers to include MRS
* origin/master:
  Change BEP numbers to include MRS
  ENH: allow _dir for other EPI (func, dwi) sequences

Conflicts:
    src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
       as promised -- was conflicting with my changes in other PR.  Tuned it
       all up so there is no dir_label now
Fix up some urls (as detected to be broken/inconsistent
additional table to recap 'volume acquisition timing'
* origin/master:
  adding extensions page
  simplify options wrt sparse sequences
  fix table fence
  check table legend
  check table legend
  hopefully last fix to list in volume timing table legend
  additional fix to list in table legend
  wrapping long lines
  BF: fix the stale anchor left from google doc, also add reference at other points
  BF: fixed a url (https -> http)
  change table legend to list
  Fixes long line
  Fixes misaligned table fence 2
  Fixes misaligned table fence
  Fixes misalignement and use of square bracket
  add table for volume timing
  highligh some fields as code, probably missed during the clean up after import from google doc
RF harmonize and thus shorten templates etc
… Inheritance principle

It is often useful to look at the top level task*json files to see what is
"common" among all subjects/sessions.  Listing only the fields with common
values is what we also implemented (albeit incorrectly, fix is pending
nipy/heudiconv#279) in ReproIn.

Upon quick search I also found no "good practice" recommendations in the
spec.  It might be arguable either spec should or should not include them.
I think it should since we already RECOMMEND things.  We of cause could
place recommendations into a separate subsection somewhere but then they
would not be linked to the specific topics and thus would not be attended
to. Hence I placed this one right at the section where it is pertinent
Based on utilization of BIDS within ReproNim and testing of BIDS in other communities (SPARC). Also developed ReproNim BIDS tutorial presented at OHBM and SfN during ReproNim training course.
Added contributor information
ENH: First(?) good practice recommendation. No excessive overrides in Inheritance principle
@franklin-feingold franklin-feingold merged commit 6268b23 into franklin-feingold:master Dec 5, 2018
franklin-feingold pushed a commit that referenced this pull request Jul 4, 2020
FIX: Link subsections in functional derivatives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.