Skip to content

[ENH] Added CBV contrast#82

Merged
chrisgorgo merged 1 commit intobids-standard:masterfrom
TheChymera:cbv
Nov 16, 2018
Merged

[ENH] Added CBV contrast#82
chrisgorgo merged 1 commit intobids-standard:masterfrom
TheChymera:cbv

Conversation

@TheChymera
Copy link
Copy Markdown
Collaborator

As discussed #63

Copy link
Copy Markdown
Contributor

@chrisgorgo chrisgorgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Does the analysis of CBV data require any additional metadata fields?
  • Would some metadata fields OPTIONAL for _bold become MANDATORY for _cbv?

@chrisgorgo
Copy link
Copy Markdown
Contributor

Thanks for sending this. It seems that you have a few syntax issues (see https://travis-ci.com/bids-standard/bids-specification/builds/90769181#L483). Have a look at https://github.com/bids-standard/bids-specification/blob/master/CONTRIBUTING.md#writing-in-markdown for tips on how to deal with Markdown.

Pinging @bids-standard/bep_leads for comments.

@TheChymera TheChymera force-pushed the cbv branch 2 times, most recently from d7f941c to 239cac0 Compare November 9, 2018 00:37
@TheChymera
Copy link
Copy Markdown
Collaborator Author

  1. Actually, yes. Added now.
  2. No

@TheChymera TheChymera force-pushed the cbv branch 2 times, most recently from 604718c to 350fe10 Compare November 9, 2018 00:46
@chrisgorgo
Copy link
Copy Markdown
Contributor

I think you need to rebase or merge to resolve conflicts before we can merge.

@TheChymera TheChymera force-pushed the cbv branch 4 times, most recently from 73bafe3 to a70b1ac Compare November 15, 2018 10:42
@TheChymera
Copy link
Copy Markdown
Collaborator Author

@chrisfilo ping

@chrisgorgo
Copy link
Copy Markdown
Contributor

Thanks!

@chrisgorgo chrisgorgo merged commit 8f41cb6 into bids-standard:master Nov 16, 2018
@TheChymera TheChymera deleted the cbv branch November 16, 2018 23:24
@chrisgorgo chrisgorgo mentioned this pull request Feb 14, 2019
@sappelhoff sappelhoff changed the title Added CBV contrast [ENH] Added CBV contrast Sep 8, 2020
arokem added a commit to arokem/bids-specification that referenced this pull request Sep 15, 2025
Fix codespell-detected British spellings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants