Skip to content

Also insert newline after 'in'#83

Closed
wldhx wants to merge 1 commit intofourmolu:let-newlinefrom
wldhx:let-newline
Closed

Also insert newline after 'in'#83
wldhx wants to merge 1 commit intofourmolu:let-newlinefrom
wldhx:let-newline

Conversation

@wldhx
Copy link
Copy Markdown
Contributor

@wldhx wldhx commented Apr 16, 2021

C.f. #77 (comment)

Not sure whether we'd like it gated by another option.

@georgefst georgefst mentioned this pull request Oct 30, 2021
@brandonchinn178 brandonchinn178 added the new config option Adds or would add new configuration option label Jan 24, 2022
@brandonchinn178
Copy link
Copy Markdown
Collaborator

👋 @wldhx
Thank you for opening this PR and being patient while we sorted out how to handle all the new contributions for new configuration options!

If you haven't noticed, we finally merged in a new testing framework for configuration options (#169)! This means we can finally address the backlog of open PRs.

Please do the following steps

  • Rebase against main

    git remote add upstream git@github.com:fourmolu/fourmolu
    git fetch upstream
    git rebase -i upstream/main
  • Resolve merge conflicts

  • Ensure CHANGELOG.md has been updated

  • Ensure configuration docs in README.md have been updated

  • Ensure fourmolu.yaml updated to stay in sync with config in README.md

  • Ensure tests have been added

You can use #135 as a reference for this checklist.

@brandonchinn178
Copy link
Copy Markdown
Collaborator

Issue: #202

I might open a new PR incorporating this and #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new config option Adds or would add new configuration option

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants