Add test framework for Fourmolu options#169
Conversation
|
cc @georgefst Thoughts on both the test strategy + the input files? Did I cover the main styling differences for each option? |
ab9f431 to
b342981
Compare
c7364ed to
40bcc74
Compare
|
Hey. Is this PR blocked by anything? |
|
Hey @arybczak! I was hoping to get @georgefst to take a look, but he seems to be busy. I'm actually going on vacation, so I was going to merge this when I get back, give George a little more time anyway |
|
FYI @3kyro this reverts the tests you added in #108, with new tests captured in https://github.com/fourmolu/fourmolu/pull/169/files#diff-2ce4cd9cc4e15f9f8fdd33721a2b90f5eade9582ca70bc09e6af9a9928fc5346. Can you check to see if there are any other cases we should test here? @georgefst To get PRs unblocked and get activity flowing again in this repo, I'm going to merge this soon. It'd be great to get your review still, whether it comes before or after I merge. |
@brandonchinn178 Yes, styling with leading and diff-friendly is terrible. A ternary option would be great to have but we can start by ignoring the diff-friendly setting when import export commas are set to leading. Let me know if there's anything I can do. |
|
@3kyro ah yes ok, I did mention that here: #108 (comment). Nothing to do now. Maybe we can take a look after I release the next version |
Resolves #49, Resolves #56
PrinterSpec.hs+data/to basically what it is in Ormolu