Skip to content

Add test framework for Fourmolu options#169

Merged
brandonchinn178 merged 16 commits intomainfrom
tests
May 30, 2022
Merged

Add test framework for Fourmolu options#169
brandonchinn178 merged 16 commits intomainfrom
tests

Conversation

@brandonchinn178
Copy link
Collaborator

@brandonchinn178 brandonchinn178 commented Apr 16, 2022

Resolves #49, Resolves #56

  • Revert PrinterSpec.hs + data/ to basically what it is in Ormolu
  • Add tests for current options
  • Add checklist to docs for adding a new config option
  • Add to docs list of current options

@brandonchinn178
Copy link
Collaborator Author

cc @georgefst Thoughts on both the test strategy + the input files? Did I cover the main styling differences for each option?

@arybczak
Copy link

Hey. Is this PR blocked by anything?

@brandonchinn178
Copy link
Collaborator Author

Hey @arybczak! I was hoping to get @georgefst to take a look, but he seems to be busy. I'm actually going on vacation, so I was going to merge this when I get back, give George a little more time anyway

@brandonchinn178
Copy link
Collaborator Author

FYI @3kyro this reverts the tests you added in #108, with new tests captured in https://github.com/fourmolu/fourmolu/pull/169/files#diff-2ce4cd9cc4e15f9f8fdd33721a2b90f5eade9582ca70bc09e6af9a9928fc5346. Can you check to see if there are any other cases we should test here?

@georgefst To get PRs unblocked and get activity flowing again in this repo, I'm going to merge this soon. It'd be great to get your review still, whether it comes before or after I merge.

@brandonchinn178
Copy link
Collaborator Author

@3kyro thanks! Updated here: 1f80c2d

The style's a bit wonky, but we can leave that off for later. I'll merge this in when CI passes

@3kyro
Copy link
Contributor

3kyro commented May 30, 2022

The style's a bit wonky, but we can leave that off for later. I'll merge this in when CI passes

@brandonchinn178 Yes, styling with leading and diff-friendly is terrible. A ternary option would be great to have but we can start by ignoring the diff-friendly setting when import export commas are set to leading. Let me know if there's anything I can do.

@brandonchinn178
Copy link
Collaborator Author

@3kyro ah yes ok, I did mention that here: #108 (comment). Nothing to do now. Maybe we can take a look after I release the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing docs for diff-friendly-import-export. Testing all options

3 participants