Skip to content

Add option for inserting newline after a 'let'#77

Closed
georgefst wants to merge 2 commits intomainfrom
let-newline
Closed

Add option for inserting newline after a 'let'#77
georgefst wants to merge 2 commits intomainfrom
let-newline

Conversation

@georgefst
Copy link
Copy Markdown
Collaborator

@georgefst georgefst commented Mar 18, 2021

No description provided.

@georgefst
Copy link
Copy Markdown
Collaborator Author

NB. we should also add to the README before merging this.

@dpwiz
Copy link
Copy Markdown

dpwiz commented Apr 13, 2021

Can it add a break after in too?

let
  foo = 1
  bar = foo * foo
in
  print (foo, bar)

Perhaps with an additional option.

@georgefst georgefst mentioned this pull request Oct 30, 2021
@brandonchinn178 brandonchinn178 added the new config option Adds or would add new configuration option label Jan 24, 2022
@brandonchinn178 brandonchinn178 force-pushed the master branch 12 times, most recently from c7364ed to 40bcc74 Compare May 18, 2022 21:03
@brandonchinn178
Copy link
Copy Markdown
Collaborator

brandonchinn178 commented Jun 1, 2022

👋 @georgefst
Thank you for opening this PR and being patient while we sorted out how to handle all the new contributions for new configuration options!

If you haven't noticed, we finally merged in a new testing framework for configuration options (#169)! This means we can finally address the backlog of open PRs.

Please do the following steps

  • Rebase against main

    git remote add upstream git@github.com:fourmolu/fourmolu
    git fetch upstream
    git rebase -i upstream/main
  • Resolve merge conflicts

  • Ensure a file has been added to changelog.d/ (see changelog.d/README.md)

  • Ensure configuration docs in README.md have been updated

  • Ensure fourmolu.yaml updated to stay in sync with config in README.md

  • Ensure tests have been added

You can use #135 as a reference for this checklist.

@brandonchinn178
Copy link
Copy Markdown
Collaborator

Issue: #202

I might open a new PR incorporating this and #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new config option Adds or would add new configuration option

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants