Skip to content

hardhat-forge: use the correct source name#51

Merged
mattsse merged 1 commit intofoundry-rs:developfrom
tynes:fix/source-name
Jun 3, 2022
Merged

hardhat-forge: use the correct source name#51
mattsse merged 1 commit intofoundry-rs:developfrom
tynes:fix/source-name

Conversation

@tynes
Copy link
Copy Markdown
Collaborator

@tynes tynes commented Jun 3, 2022

The relative path to the file from the root
of the project should be used as the source name
in the artifact.

Closes #36

This will fix tooling that depends on the source name:
https://github.com/defi-wonderland/smock/blob/27fe7a5f3c351714257cdc98204e282932c11e12/src/utils/storage.ts#L54

The relative path to the file from the root
of the project should be used as the source name
in the artifact.

Closes foundry-rs#36

This will fix tooling that depends on the source name:
https://github.com/defi-wonderland/smock/blob/27fe7a5f3c351714257cdc98204e282932c11e12/src/utils/storage.ts#L54
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 3, 2022

🦋 Changeset detected

Latest commit: 60324b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@foundry-rs/hardhat-forge Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 7ed40a4 into foundry-rs:develop Jun 3, 2022
mattsse added a commit that referenced this pull request Jun 15, 2022
* fix(hh/forge): typechain support (#45)

Typechain uses a private method on the artifact
with an unsafe `any` typecast to get artifact paths.
To work with typechain, this method must exist until
typechain is updated.

The issue is here: dethcrypto/TypeChain#544

* feat: `Artifacts.getBuildInfo` (#48)

Implement a naive `getBuildInfo` function. This is useful
for tooling that integrates more deeply with the hardhat ecosystem.
Note that this implementation is not 100% with the output
that the hardhat compiler toolchain outputs, but the output
is good enough to get more tooling to be compatible.

* hardhat-forge: use the correct source name (#51)

The relative path to the file from the root
of the project should be used as the source name
in the artifact.

Closes #36

This will fix tooling that depends on the source name:
https://github.com/defi-wonderland/smock/blob/27fe7a5f3c351714257cdc98204e282932c11e12/src/utils/storage.ts#L54

* test: explicitly set port for anvil (#53)

* test: explicitly set port for anvil

* chore: add changeset

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
tynes added a commit that referenced this pull request Jun 21, 2022
The relative path to the file from the root
of the project should be used as the source name
in the artifact.

Closes #36

This will fix tooling that depends on the source name:
https://github.com/defi-wonderland/smock/blob/27fe7a5f3c351714257cdc98204e282932c11e12/src/utils/storage.ts#L54
gakonst added a commit that referenced this pull request Jun 24, 2022
* Version Packages (#44)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(hh/forge): typechain support (#45) (#46)

Typechain uses a private method on the artifact
with an unsafe `any` typecast to get artifact paths.
To work with typechain, this method must exist until
typechain is updated.

The issue is here: dethcrypto/TypeChain#544

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

* Version Packages (#47)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Merge develop into master (#49)

* fix(hh/forge): typechain support (#45)

Typechain uses a private method on the artifact
with an unsafe `any` typecast to get artifact paths.
To work with typechain, this method must exist until
typechain is updated.

The issue is here: dethcrypto/TypeChain#544

* feat: `Artifacts.getBuildInfo` (#48)

Implement a naive `getBuildInfo` function. This is useful
for tooling that integrates more deeply with the hardhat ecosystem.
Note that this implementation is not 100% with the output
that the hardhat compiler toolchain outputs, but the output
is good enough to get more tooling to be compatible.

* Version Packages

* Merge develop into master (#55)

* fix(hh/forge): typechain support (#45)

Typechain uses a private method on the artifact
with an unsafe `any` typecast to get artifact paths.
To work with typechain, this method must exist until
typechain is updated.

The issue is here: dethcrypto/TypeChain#544

* feat: `Artifacts.getBuildInfo` (#48)

Implement a naive `getBuildInfo` function. This is useful
for tooling that integrates more deeply with the hardhat ecosystem.
Note that this implementation is not 100% with the output
that the hardhat compiler toolchain outputs, but the output
is good enough to get more tooling to be compatible.

* hardhat-forge: use the correct source name (#51)

The relative path to the file from the root
of the project should be used as the source name
in the artifact.

Closes #36

This will fix tooling that depends on the source name:
https://github.com/defi-wonderland/smock/blob/27fe7a5f3c351714257cdc98204e282932c11e12/src/utils/storage.ts#L54

* test: explicitly set port for anvil (#53)

* test: explicitly set port for anvil

* chore: add changeset

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* Version Packages (#56)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: `Artifacts.getBuildInfo` (#48)

Implement a naive `getBuildInfo` function. This is useful
for tooling that integrates more deeply with the hardhat ecosystem.
Note that this implementation is not 100% with the output
that the hardhat compiler toolchain outputs, but the output
is good enough to get more tooling to be compatible.

* hardhat-forge: use the correct source name (#51)

The relative path to the file from the root
of the project should be used as the source name
in the artifact.

Closes #36

This will fix tooling that depends on the source name:
https://github.com/defi-wonderland/smock/blob/27fe7a5f3c351714257cdc98204e282932c11e12/src/utils/storage.ts#L54

* test: explicitly set port for anvil (#53)

* test: explicitly set port for anvil

* chore: add changeset

* feat: better `BuildInfo` support (#59)

* feat(hardhat-forge): better `BuildInfo` support

Requires foundry with foundry-rs/foundry@6ce16a4.
Generates the debug files for easy access to the build info files
during hardhat scripts.

* feat(hardhat-forge): buildinfo tests

* feat(hardhat-forge): better `BuildInfo` support

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardhat Artifact Source Name incorrect

2 participants