Skip to content

Use of private hardhat artifacts function in task definition causes tests to break #544

@zoeyTM

Description

@zoeyTM

Hi there 👋

I'm a new engineer over on the Hardhat team; nice to meet you!

I've been working on a new feature in our artifacts code, and I ran into a bit of a snag with the TypeChain plugin. It looks like one of the private functions I changed is being used in your hardhat plugin:

artifactFQNs.map((fqn) => (artifacts as any)._getArtifactPathFromFullyQualifiedName(fqn)),

As a long-term solution, I'll add a public function to my PR that mimics the current functionality of the private version you're using in your task. That public API will be preserved moving forward so we won't run into this issue again :)

Given that we don't want to push breaking code for any existing users, I'll keep the current private method that you're using unchanged, until some time in the future when you've updated to the new function and we can safely deprecate the private one.

I'll make another comment here once my PR has been merged to let you know the name of the public function being added.

Thanks! Let me know if you have any additional thoughts or concerns around this.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions