Skip to content

fix: replace deprecated url.parse() with new URL()#1803

Merged
titanism merged 1 commit intoforwardemail:masterfrom
alumni:fix-url-parse
Apr 29, 2024
Merged

fix: replace deprecated url.parse() with new URL()#1803
titanism merged 1 commit intoforwardemail:masterfrom
alumni:fix-url-parse

Conversation

@alumni
Copy link
Copy Markdown
Contributor

@alumni alumni commented Apr 25, 2024

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Replaces the other occurrences of url.parse() with new URL(). Continuation of PR #1802.

@titanism
Copy link
Copy Markdown
Collaborator

titanism commented Apr 26, 2024

Can you fix merge conflict @alumni ?

@titanism titanism mentioned this pull request Apr 26, 2024
Merged
6 tasks
@titanism titanism merged commit 329cc63 into forwardemail:master Apr 29, 2024
@titanism
Copy link
Copy Markdown
Collaborator

titanism commented Apr 29, 2024

released in v9.0.2

https://github.com/ladjs/superagent/releases/tag/v9.0.2

@perrin4869 perrin4869 mentioned this pull request May 13, 2024
Merged
@foresterre
Copy link
Copy Markdown

foresterre commented May 14, 2024

This is possibly a breaking change. Previously, a value like "0.0.0.0" was accepted, while it now errors with "0.0.0.0 is not a valid URL"

@albogdano albogdano mentioned this pull request May 21, 2024
Closed
@gramakri
Copy link
Copy Markdown

gramakri commented Jun 10, 2024

@alumni I think this change broke IPv6 queries. See #1805 . The change makes node resolve [x]:port as a hostname instead of IPv6 address.

@alumni
Copy link
Copy Markdown
Contributor Author

alumni commented Jun 10, 2024

There's a pr open to fix it ;)

@gramakri
Copy link
Copy Markdown

gramakri commented Jun 10, 2024

@alumni ah, I was hoping you would review that PR :-D (also, there was an edit in that PR saying it's hard to test)

@TheGamerzs TheGamerzs mentioned this pull request Jul 21, 2024
Open
alxndrsn pushed a commit to alxndrsn/odk-central-backend that referenced this pull request Mar 20, 2025
Update test dependency supertest (6.3.3 -> 7.0.0)
80013f9 
Related: getodk#1440

This is a precursor to updating supertest to v7.1.0.

supertest v7.1.0 updates superagent from v9.0.1 to v9.0.2, which introduces a breaking change courtesy of forwardemail/superagent#1803
This was referenced Mar 20, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alumni @titanism @foresterre @gramakri