Hi there @alumni - it looks like npm test is not working as the linting fails, e.g. npx xo fails linting. Also there are other cases where node: prefix is not being used and old url approach is still there (e.g. tests folder). Can you fix all these? You may need to bump xo and eslint deps to fix linting warnings and update .xo-config.js.

I'll try to take a look. The multipart test times out for me even in the commit before the merge.

I managed to replace the deprecated parse in other places as well. make test-node seems to have identical output as the one in other recent commits on the master branch. I can submit a PR for that.

Regarding the linting problem - unless there's a known to be working npm lockfile, it will be quite difficult to figure out what's wrong - xo has changed completely since it was last upgraded, so upgrading it now seems to be a major task.

See #1803 (comment) @alumni

Hey, I am pretty sure this is a breaking change that snuck in. And unfortunately this means some tests which the send module use to ensure you cannot path escape are broken because of it. new URL will flatten out request paths with .. and . segments but node:url did not have this behavior (I could probably do more to prove this, but I am pretty sure).

In normal circumstances this is a good thing, but in this case it means we cannot use supertest to test this case anymore. I am not sure it makes sense really to try and revert this, and send is using 6.2.2 so we expected some breaking changes in trying to upgrade, but just wanted to flag that this is technically breaking in a patch.

Secondly, I am not sure how we can use supertest and superagent anymore in these tests now that it is modifying the intended test behavior. Any ideas on how we could do this kind of test and still upgrade? https://github.com/pillarjs/send/blob/master/test/send.js#L1406-L1410

Ah, came to ask about this breaking change being shipped in a patch version and I see @wesleytodd already beat me. Since it's a patch of a major, fair enough I suppose. It would be nice to retroactively note this breaking change in the release notes, as well as in supertest@7.0.0

We have tests in express that break on the normalization being done by new URL("http://example.com/../../foo")
https://github.com/expressjs/express/blob/64e7373d6976dd3ec32a92dbc31ff19700fe152a/test/acceptance/downloads.js#L40-L47