Techdebt examples bootstrapping v2#1928
Merged
Merged
Conversation
…alled from outside)
Collaborator
|
Great PR, lots of duplicated code is now gone. Merging! |
NtAlexio2
pushed a commit
to NtAlexio2/impacket
that referenced
this pull request
Jul 13, 2025
* Standardized examples logger init method * Fixing missing import * Standardized examples init_ldap_session function fortra#1 * Calling new shared function _ldap3_kerberos_login from example addcomputer * Removed considering -debug in each example. Now it's handled in utils. * Standardized EMPTY_LM_HASH in impacket.examples.utils * Unify parse_identity function (phase 1) * Standardized parse_identity * Renamed "_ldap3_kerberos_login" to "ldap3_kerberos_login" (as it is called from outside) * Standardize "logger" init in regsecrets.py * Standardized LDAP login into a single function in utils.py:ldap_login
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created as a replacement of #1918
This PR aims to standardize some examples requirements and group them in a single utils script that could be leveraged by existing and future examples.
Shared Functionality
Logging initialization
-tsand-debugto every exampleimpacket/impacket/examples/logger.py
Line 57 in 5af6529
LDAP Login
impacket/impacket/examples/utils.py
Line 101 in 5af6529
impacket/impacket/examples/utils.py
Line 248 in 5af6529
impacket/impacket/examples/utils.py
Line 274 in 5af6529
Identity Parsing
impacket/impacket/examples/utils.py
Line 309 in 5af6529