Standardize examples requirements and common functionality#1918
Closed
gabrielg5 wants to merge 15 commits into
Closed
Standardize examples requirements and common functionality#1918gabrielg5 wants to merge 15 commits into
gabrielg5 wants to merge 15 commits into
Conversation
…alled from outside)
…1908) * fixed NETLOGON auth error * use getSSPType1 func to create NlAuthMessage
* Add option to dump relayed hashes to console (ntlmrelayx) * Add Documentation * Simplify print statements * Update README.md Reverted changes in the README.md file in preparation for merge. --------- Co-authored-by: p0rtL6 <p0rtl.pue@gmail.com> Co-authored-by: Gabriel Gonzalez <gabriel.gonzalez@fortra.com>
Co-authored-by: laxa <laxa@ddracepro.net>
A small contribution to add autocomplete functionality to the `cat command, similar to `cd`.
gabrielg5
added a commit
that referenced
this pull request
Mar 27, 2025
Removed extra parameter in _init_ldap_connection() (From #1918)
gabrielg5
added a commit
that referenced
this pull request
Mar 27, 2025
Removed some exception handling in _get_machine_name to make it valid for all examples using it (From #1918 and #1923 (comment))
NtAlexio2
pushed a commit
to NtAlexio2/impacket
that referenced
this pull request
Jul 13, 2025
Removed extra parameter in _init_ldap_connection() (From fortra#1918)
NtAlexio2
pushed a commit
to NtAlexio2/impacket
that referenced
this pull request
Jul 13, 2025
Removed some exception handling in _get_machine_name to make it valid for all examples using it (From fortra#1918 and fortra#1923 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to standardize some examples requirements and group them in a single utils script that could be leveraged by existing and future examples.
Shared Functionality
Logging initialization
-tsand-debugto every exampleimpacket/impacket/examples/logger.py
Line 57 in 8b4e374
LDAP Login
impacket/impacket/examples/utils.py
Line 86 in 8b4e374
impacket/impacket/examples/utils.py
Line 233 in 8b4e374
Identity Parsing
impacket/impacket/examples/utils.py
Line 258 in 8b4e374