[Impeller] Avoid using the major and minor variable names.#36009
Conversation
Fixes flutter/flutter#110936 In some versions of GNU libc, these are macros. The man page says "major(), and minor() functions are not specified in POSIX.1, but are present on many other systems". Just so happens that its not on any systems we build on in CI. We could do complicated macro management using scopes or undefining these the right spot. I just renamed them to avoid collisions.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @jwinarske |
|
@jwinarske If this addresses your issue, could you indicate whether a cherry-pick would be helpful? |
|
auto label is removed for flutter/engine, pr: 36009, due to - The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bdero
left a comment
There was a problem hiding this comment.
iOS build failure looked like a transient builder problem, so just reran.
|
NVM, not transient. It's flutter/flutter#111193 |
|
@zanderso I'll QC the fix on my end now |
|
@zanderso No regression on 64-bit builds. Running 32-bit build matrix now. |
|
@zanderso that's a confirmed fix for 32-bit issue reported. A cherry pick would be helpful. |
Fixes flutter/flutter#110936
In some versions of GNU libc, these are macros. The man page says "major(), and minor() functions are not specified in POSIX.1, but are present on many other systems". Just so happens that its not on any systems we build on in CI.
We could do complicated macro management using scopes or undefining these the right spot. I just renamed them to avoid collisions.
The most useful resource I found on this subject was https://stackoverflow.com/a/22253389/38070.