Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Avoid using the major and minor variable names. (#36009)#36054

Merged
itsjustkevin merged 1 commit into
flutter-team-archive:flutter-3.2-candidate.5from
zanderso:cp-build-fix
Sep 12, 2022
Merged

[Impeller] Avoid using the major and minor variable names. (#36009)#36054
itsjustkevin merged 1 commit into
flutter-team-archive:flutter-3.2-candidate.5from
zanderso:cp-build-fix

Conversation

@zanderso

@zanderso zanderso commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

@flutter-dashboard flutter-dashboard Bot changed the base branch from flutter-3.2-candidate.5 to main September 9, 2022 20:20
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot added embedder Related to the embedder API platform-android platform-web Code specifically for the web engine platform-windows labels Sep 9, 2022
@zanderso zanderso changed the base branch from main to flutter-3.2-candidate.5 September 9, 2022 20:21
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@skia-gold

Copy link
Copy Markdown

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/36054

@keyonghan

Copy link
Copy Markdown
Contributor

https://flutter-review.googlesource.com/c/recipes/+/33742 to unblock Mac iOS Engine failure.

@itsjustkevin itsjustkevin merged commit d3d18fd into flutter-team-archive:flutter-3.2-candidate.5 Sep 12, 2022
@zanderso zanderso deleted the cp-build-fix branch September 15, 2022 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

e: impeller embedder Related to the embedder API needs tests platform-android platform-web Code specifically for the web engine platform-windows

Development

Successfully merging this pull request may close these issues.

6 participants