Update builders to Xcode 13 and macOS 12 by jmagman · Pull Request #31915 · flutter-team-archive/engine

jmagman · 2022-03-09T01:27:29Z

Leave Mac Web Builder on Xcode 12.3 due to flutter/flutter#99885. Upgrade all other builders.
Fixes flutter/flutter#99698
Fixes flutter/flutter#85555

Blocking flutter/flutter#94078

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-03-09T01:35:11Z

+          {"name":"xcode_runtime_ios-13-0","path":"xcode_runtime_ios-13-0"},
+          {"name":"xcode_runtime_ios-15-0","path":"xcode_runtime_ios-15-0"}


Something like this
https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/osx_sdk/api.py#110

jmagman · 2022-03-09T01:37:51Z

+      runtime_versions: >-
+        [
+          "ios-13",
+          "ios-15"
+        ]


https://flutter-review.googlesource.com/c/infra/+/27742/comments/6a769d18_cc8d83ec

jmagman · 2022-03-09T01:44:52Z

        [
          {"name":"flutter_cocoapods","path":"cocoapods"},
-          {"name":"old_osx_sdk","path":"osx_sdk"},
+          {"name":"osx_sdk_13a233_13_15","path":"osx_sdk"},


I'm not sure what old_osx_sdk should be renamed to given flutter/flutter#99586 since the names were different between the engine and framework. osx_sdk_13a233_13_15 is for Xcode 13a233 + iOS 13 + iOS 15 but I'm open to suggestions here.

old_osx_sdk and osx_sdk were used to transition between two versions of xcode without impacting the builders. Now that we need multiple caches updating the name with version string is a better option.

jmagman · 2022-03-09T02:19:05Z

    scheduler: luci
    runIf:
      - DEPS
+      - .ci.yaml


The web tests should run on PRs like this one that change their configurations.

jmagman · 2022-03-09T22:36:35Z

Tests will fail until flutter/cocoon#1652 is published.

yusuf-goog

LGTM with a question. @godofredoc should Ok the cache related changes.

yusuf-goog · 2022-03-09T22:43:23Z

+      os: Mac-12
+      runtime_versions: >-
+        [
+          "ios-13",


Some places, these are specified as ios-13-0. Not sure if it matters?

In the past we were tracking minor versions just to be sure that updates were not breaking the builds and or generating different performance results.

You were right, these need to match the cipd refs, ios-13-0 etc

#0 mac_toolchain/install.go:311 - main.resolveRuntimeRef() reason: Failed to resolve runtime ref given runtime version: ios-13, xcode version: .

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8820126450450034161/+/u/install_xcode_runtime_ios-13/stdout

jmagman · 2022-03-09T23:21:14Z

Both of these are running with old versions of macOS and Xcode? The rest of the tests picked up the properties though.
https://ci.chromium.org/p/flutter/builders/try/Mac%20Unopt/9950?
https://ci.chromium.org/p/flutter/builders/try/Mac%20Web%20Engine/23525?

jmagman · 2022-03-09T23:35:47Z

Rebasing to run them again on published flutter/cocoon#1652

CaseyHillers · 2022-03-09T23:44:17Z

Rebasing to run them again on published https://github.com/flutter/cocoon/pull/1652[](https://github.com/jmagman)

Sorry to be nitty, but for future infra issues can you merge instead of rebase? GitHub wipe's check run state on rebase so it's hard for me to take action on why the properties weren't propagating

jmagman · 2022-03-09T23:45:02Z

Rebasing to run them again on published [https://github.com/flutter/cocoon/pull/1652 ](flutter/cocoon#1652)

Sorry to be nitty, but for future infra issues can you merge instead of rebase? GitHub wipe's check run state on rebase so it's hard for me to take action on why the properties weren't propagating

Will do. 🙂

jmagman · 2022-03-10T01:03:21Z

Mac Web Engine felt ios-safari test tests timing out, filed flutter/flutter#99885

keyonghan · 2022-03-15T22:07:50Z

/cc @godofredoc

chinmaygarde · 2022-03-24T20:07:24Z

@jmagman I believe a rebase ought to unblock this patch. Are there blockers other than presubmits here?

jmagman · 2022-03-25T00:29:37Z

This is blocked on flutter/flutter#99885. Making a draft.

flutter-dashboard · 2022-03-25T00:34:16Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

CaseyHillers · 2022-03-29T20:02:43Z

The ci.yaml roller failed on this PR - https://ci.chromium.org/ui/p/flutter/builders/staging/Linux%20ci_yaml%20engine%20roller/2084/overview

The caches change contains invalid characters. You'll need to swap the special characters to only be underscores

…e/engine#31915)

…eam-archive#32324)

jmagman self-assigned this Mar 9, 2022

jmagman changed the title ~~Update tests to Xcode 13 and macOS 12~~ Update builders to Xcode 13 and macOS 12 Mar 9, 2022

jmagman commented Mar 9, 2022

View reviewed changes

jmagman force-pushed the xcode-13 branch from 3d34821 to a7580e4 Compare March 9, 2022 02:18

jmagman commented Mar 9, 2022

View reviewed changes

jmagman force-pushed the xcode-13 branch from a7580e4 to 8587363 Compare March 9, 2022 21:56

jmagman requested review from godofredoc and yusuf-goog March 9, 2022 22:35

yusuf-goog approved these changes Mar 9, 2022

View reviewed changes

godofredoc approved these changes Mar 9, 2022

View reviewed changes

jmagman force-pushed the xcode-13 branch from 8587363 to ae902b5 Compare March 9, 2022 23:35

yusuf-goog approved these changes Mar 9, 2022

View reviewed changes

jmagman mentioned this pull request Mar 10, 2022

Mac Web Engine timing out on Safari on Xcode 13.* flutter/flutter#99885

Closed

jmagman marked this pull request as draft March 25, 2022 00:29

jmagman force-pushed the xcode-13 branch from fe0705a to 020be66 Compare March 25, 2022 17:20

jmagman mentioned this pull request Mar 25, 2022

engine try job did not pick up os, runtime_versions, or xcode config changes flutter/flutter#100797

Closed

godofredoc approved these changes Mar 28, 2022

View reviewed changes

jmagman added 14 commits March 28, 2022 19:49

Update tests to Xcode 13 and macOS 12

e8bd6a6

chomp

51afabb

Rename old_osx_sdk

3cfaa88

Run web tests

8a87254

Minor version

0b79345

See if iOS 15 Safari launches

91a6929

revert sim version

0bb7f47

Try overriding Mac Web Engine properties

30a0ccd

iOS 13 in all tests

6ec39de

Cache block

a8f3d9e

comma

8d3b160

Web engine builder on original Xcode version

ce467b4

Override runtime list

f306690

empty

a2063cd

jmagman force-pushed the xcode-13 branch from 55cb670 to a2063cd Compare March 29, 2022 02:49

jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 29, 2022

fluttergithubbot merged commit 5400d74 into flutter-team-archive:main Mar 29, 2022

jmagman deleted the xcode-13 branch March 29, 2022 17:59

CaseyHillers pushed a commit that referenced this pull request Mar 29, 2022

Trigger latest LUCI configs for #31915 (#32324)

6ad06a5

jmagman mentioned this pull request Mar 29, 2022

Upgrade Mac builders to macOS Big Sur 11.3 or higher flutter/flutter#94078

Closed

engine-flutter-autoroll mentioned this pull request Mar 30, 2022

Roll Engine from 0e7773bcca40 to 6ad06a5d891b (2 revisions) flutter/flutter#101006

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2022

5400d74 Update builders to Xcode 13 and macOS 12 (flutter-team-archiv…

3265462

…e/engine#31915)

gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Mar 30, 2022

Trigger latest LUCI configs for flutter-team-archive#31915 (flutter-t…

3c9c1cd

…eam-archive#32324)

		{"name":"xcode_runtime_ios-13-0","path":"xcode_runtime_ios-13-0"},
		{"name":"xcode_runtime_ios-15-0","path":"xcode_runtime_ios-15-0"}

Uh oh!

Conversation

jmagman commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman commented Mar 9, 2022

Uh oh!

yusuf-goog left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Mar 9, 2022

Uh oh!

CaseyHillers commented Mar 9, 2022

Uh oh!

jmagman commented Mar 9, 2022

Uh oh!

jmagman commented Mar 10, 2022

Uh oh!

keyonghan commented Mar 15, 2022

Uh oh!

chinmaygarde commented Mar 24, 2022

Uh oh!

jmagman commented Mar 25, 2022

Uh oh!

flutter-dashboard Bot commented Mar 25, 2022

Uh oh!

CaseyHillers commented Mar 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

jmagman commented Mar 9, 2022 •

edited

Loading

jmagman commented Mar 9, 2022 •

edited

Loading