Skip to content

Conversation

@yusuf-goog
Copy link
Contributor

Add entry into $flutter/osx_sdk dict, from runtime_versions value in
ci.yaml.

Bug:99698

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Add entry into $flutter/osx_sdk dict, from runtime_versions value in
ci.yaml.

Bug:99698
@yusuf-goog
Copy link
Contributor Author

These pull the runtime_verions property in for the presubmit tasks. For postsubmit: https://flutter-review.googlesource.com/c/infra/+/27742

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @CaseyHillers should also review

@yusuf-goog yusuf-goog self-assigned this Mar 9, 2022
@yusuf-goog yusuf-goog added the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Mar 9, 2022
@fluttergithubbot fluttergithubbot merged commit 99657a5 into flutter:main Mar 9, 2022
@yusuf-goog yusuf-goog deleted the runtimeversions branch March 9, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants