Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Enable lazy-async-stacks by-default in all modes (Take 3)"#21043

Merged
zanderso merged 1 commit into
masterfrom
revert-20895-labd
Sep 9, 2020
Merged

Revert "Enable lazy-async-stacks by-default in all modes (Take 3)"#21043
zanderso merged 1 commit into
masterfrom
revert-20895-labd

Conversation

@zanderso

@zanderso zanderso commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

@zanderso

zanderso commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

Landing revert before presubmits finish to help unblock the roll to the framework.

@zanderso zanderso merged commit f7c7b41 into master Sep 9, 2020
@zanderso zanderso deleted the revert-20895-labd branch September 9, 2020 16:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020
@engine-flutter-autoroll
f7c7b41 Revert "Enable lazy-async-stacks by-default in all modes (Tak…
8da82b1 
…e 3) (flutter#20895)" (flutter-team-archive/engine#21043)
zanderso pushed a commit to flutter/flutter that referenced this pull request Sep 9, 2020
@engine-flutter-autoroll
Roll Engine from d1d848e to f7c7b41 (34 revisions) (#65492)
a0b6538 
* 556cb23 Roll Skia from 6763a713f957 to d91cd6b5ee2b (3 revisions) (flutter-team-archive/engine#20989)

* b6a3c54 Roll Fuchsia Linux SDK from A0PKwETay... to gfAt63Ezd... (flutter-team-archive/engine#21005)

* cceb733 Roll Fuchsia Mac SDK from sih5f60Gt... to 9pfHLZEFU... (flutter-team-archive/engine#21006)

* 5539820 Roll Skia from d91cd6b5ee2b to a73a84f9b8e3 (1 revision) (flutter-team-archive/engine#21007)

* b4cc631 Roll Dart SDK from f3a9ca88b664 to e59935669cb0 (1 revision) (flutter-team-archive/engine#21008)

* 6cf0cc4 Roll Skia from a73a84f9b8e3 to d0fe7d37d678 (1 revision) (flutter-team-archive/engine#21011)

* 5b055bb Roll Skia from d0fe7d37d678 to 611a52108b01 (2 revisions) (flutter-team-archive/engine#21012)

* 575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (flutter-team-archive/engine#20895)

* 040a794 Roll Fuchsia Mac SDK from 9pfHLZEFU... to tUwahggJ8... (flutter-team-archive/engine#21013)

* 22cca4c Roll Dart SDK from e59935669cb0 to f745f9447ddf (1 revision) (flutter-team-archive/engine#21014)

* 539cb69 Roll Fuchsia Linux SDK from gfAt63Ezd... to Ta3F40BV6... (flutter-team-archive/engine#21015)

* 7d927dd Roll Dart SDK from f745f9447ddf to b88c06c314f4 (1 revision) (flutter-team-archive/engine#21016)

* 09a5bf7 Tweak the mdns error message (flutter-team-archive/engine#20991)

* d0d9ce6 Roll Fuchsia Linux SDK from Ta3F40BV6... to coVjRTWSf... (flutter-team-archive/engine#21018)

* 808bb85 Roll Fuchsia Mac SDK from tUwahggJ8... to TyNHQXzNU... (flutter-team-archive/engine#21019)

* 5aa6921 Roll Skia from 611a52108b01 to cd54c8385c31 (2 revisions) (flutter-team-archive/engine#21021)

* e7d558f Roll Dart SDK from b88c06c314f4 to 33b6c95936e0 (2 revisions) (flutter-team-archive/engine#21023)

* af90dd3 Roll Skia from cd54c8385c31 to c0d3495e1ee2 (12 revisions) (flutter-team-archive/engine#21024)

* f0fb74b Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. (flutter-team-archive/engine#20980)

* 6a6c23a Roll Skia from c0d3495e1ee2 to cf1a4f50121f (6 revisions) (flutter-team-archive/engine#21026)

* 716dce0 Android 30r3 (flutter-team-archive/engine#21025)

* 7431070 Roll Dart SDK from 33b6c95936e0 to a2c9cae4dcd8 (1 revision) (flutter-team-archive/engine#21027)

* cef383d Roll Skia from cf1a4f50121f to 04b9443274cf (2 revisions) (flutter-team-archive/engine#21028)

* cf8c6b8 Update web lerpDouble to match C++ behaviour (flutter-team-archive/engine#21010)

* 6866675 Roll Skia from 04b9443274cf to b8ae7fa12aa0 (1 revision) (flutter-team-archive/engine#21030)

* c538f40 Roll Dart SDK from a2c9cae4dcd8 to ffbfa2000435 (1 revision) (flutter-team-archive/engine#21031)

* 89d34b0 Roll Skia from b8ae7fa12aa0 to 445c8ebcb710 (1 revision) (flutter-team-archive/engine#21032)

* 7766d2e Roll Fuchsia Mac SDK from TyNHQXzNU... to Phn3nF_BJ... (flutter-team-archive/engine#21034)

* e3de8d0 Roll Fuchsia Linux SDK from coVjRTWSf... to eBus_y4DN... (flutter-team-archive/engine#21035)

* beb7df5 Roll Skia from 445c8ebcb710 to f9d5940fef55 (3 revisions) (flutter-team-archive/engine#21037)

* f3a17b6 Roll Skia from f9d5940fef55 to 81c6d6eeb4cf (1 revision) (flutter-team-archive/engine#21038)

* bbcc495 Roll Dart SDK from ffbfa2000435 to 2e838b7b4503 (2 revisions) (flutter-team-archive/engine#21039)

* 61062fd Roll Skia from 81c6d6eeb4cf to 81606b5d9774 (5 revisions) (flutter-team-archive/engine#21041)

* f7c7b41 Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#20895)" (flutter-team-archive/engine#21043)
@mkustermann

mkustermann commented Oct 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

After quite some debugging we believe to have found out what the root cause of this windows failure is:

Flutter testing infrastructure uses package:test and package:stack_trace. The latter does not correctly handle <asynchronous gap> markers - more specifically it assumes there are only such gaps between frames. If there is such a gap at the very last frame (for which no caller was found) it will treat it as a real frame. It will then treat this as a file path - which fails on windows due to the < which cannot appear in file names:


Unsupported operation: Illegal character in path: <asynchronous
#0      _Uri._checkWindowsPathReservedCharacters (dart:core/uri.dart:1734:11)
#1      _Uri._toWindowsFilePath (dart:core/uri.dart:2745:7)
#2      _Uri.toFilePath (dart:core/uri.dart:2720:38)
#3      JsonReporter._addFrameInfo (package:test_core/src/runner/reporter/json.dart:313:21)
#4      JsonReporter._onTestStarted (package:test_core/src/runner/reporter/json.dart:136:15)
#5      _rootRunUnary (dart:async/zone.dart:1206:13)
...
#19     LiveSuiteController.reportLiveTest (package:test_core/src/runner/live_suite_controller.dart:147:30)
#20     Engine._runLiveTest (package:test_core/src/runner/engine.dart:377:21)
<asynchronous suspension>
#21     Engine._runGroup (package:test_core/src/runner/engine.dart:330:19)
#22     Engine.run.<anonymous closure>.<anonymous closure> (package:test_core/src/runner/engine.dart:275:17)
<asynchronous suspension>
#23     Engine.run.<anonymous closure>.<anonymous closure> (package:test_core/src/runner/engine.dart)
#24     Engine.run.<anonymous closure> (package:test_core/src/runner/engine.dart:281:8)
#25     _rootRunUnary (dart:async/zone.dart:1198:47)
#26     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
...

This failure in the test framework then causes cascading failures - such as a racy shutdown which causes the compilation service is not available error.

@cskau-g Will try to address this in upstream package:stack_trace and then we'll re-land this CL.

@zanderso In the future, please try to CC authors when reverting a PR - we actually only noticed this over a month later (gerrit puts people from original CL automatically on CC on a revert, unfortunately it don't seem like this on github)

@zanderso

zanderso commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

Whoops. Sorry about that. I thought github would send a notification to folks on the reverted PR without the CC on the revert PR, but it looks like I was wrong.

@ghost ghost mentioned this pull request Oct 13, 2020
Merged
@mkustermann mkustermann mentioned this pull request Oct 14, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jason-simmons jason-simmons jason-simmons approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @mkustermann @jason-simmons @googlebot