Enable lazy-async-stacks by-default in all modes (Take 3) · Pull Request #20895 · flutter-team-archive/engine

ghost · 2020-08-31T06:42:45Z

This is a third attempt at #16556 which was last reverted in #20165.

A fix for what we believe to have caused the issue that triggered the last rollback has landed upstream in Dart in dart-lang/sdk@0004589

I have manually run and verified that the relevant tests pass locally:

$ cd ~/src/flutter/flutter/ 
$ SHARD=tool_tests SUBSHARD=integration \
    ./bin/cache/dart-sdk/bin/dart ./dev/bots/test.dart \
        --local-engine=host_debug \
        --local-engine-src-path ~/src/flutter/engine/src

Original CL description:

This was already enabled by-default in AOT mode in [0] - which made the
gen_snapshot invocations use "--lazy-async-stacks --no-causal-async-stacks".

This change does the same with the engine defaults, which makes this be enabled
by-default in JIT mode as well.

See go/dart-10x-faster-async for more information.

[0] flutter/flutter@3478232

ghost · 2020-09-03T11:47:30Z

[+ @zanderso who reviewed the previous CL]

zanderso

lgtm, but please wait to land until there is a successful engine -> framework roll: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

mkustermann · 2020-09-07T08:52:45Z

lgtm, but please wait to land until there is a successful engine -> framework roll

There was a successful roll over the weekend. So let's land this.

…utter-team-archive/engine#20895)

…0895)" This reverts commit 575a519.

…0895)" (#21043) This reverts commit 575a519.

…utter-team-archive/engine#20895)

* 556cb23 Roll Skia from 6763a713f957 to d91cd6b5ee2b (3 revisions) (flutter-team-archive/engine#20989) * b6a3c54 Roll Fuchsia Linux SDK from A0PKwETay... to gfAt63Ezd... (flutter-team-archive/engine#21005) * cceb733 Roll Fuchsia Mac SDK from sih5f60Gt... to 9pfHLZEFU... (flutter-team-archive/engine#21006) * 5539820 Roll Skia from d91cd6b5ee2b to a73a84f9b8e3 (1 revision) (flutter-team-archive/engine#21007) * b4cc631 Roll Dart SDK from f3a9ca88b664 to e59935669cb0 (1 revision) (flutter-team-archive/engine#21008) * 6cf0cc4 Roll Skia from a73a84f9b8e3 to d0fe7d37d678 (1 revision) (flutter-team-archive/engine#21011) * 5b055bb Roll Skia from d0fe7d37d678 to 611a52108b01 (2 revisions) (flutter-team-archive/engine#21012) * 575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (flutter-team-archive/engine#20895) * 040a794 Roll Fuchsia Mac SDK from 9pfHLZEFU... to tUwahggJ8... (flutter-team-archive/engine#21013) * 22cca4c Roll Dart SDK from e59935669cb0 to f745f9447ddf (1 revision) (flutter-team-archive/engine#21014) * 539cb69 Roll Fuchsia Linux SDK from gfAt63Ezd... to Ta3F40BV6... (flutter-team-archive/engine#21015) * 7d927dd Roll Dart SDK from f745f9447ddf to b88c06c314f4 (1 revision) (flutter-team-archive/engine#21016) * 09a5bf7 Tweak the mdns error message (flutter-team-archive/engine#20991) * d0d9ce6 Roll Fuchsia Linux SDK from Ta3F40BV6... to coVjRTWSf... (flutter-team-archive/engine#21018) * 808bb85 Roll Fuchsia Mac SDK from tUwahggJ8... to TyNHQXzNU... (flutter-team-archive/engine#21019) * 5aa6921 Roll Skia from 611a52108b01 to cd54c8385c31 (2 revisions) (flutter-team-archive/engine#21021) * e7d558f Roll Dart SDK from b88c06c314f4 to 33b6c95936e0 (2 revisions) (flutter-team-archive/engine#21023) * af90dd3 Roll Skia from cd54c8385c31 to c0d3495e1ee2 (12 revisions) (flutter-team-archive/engine#21024) * f0fb74b Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. (flutter-team-archive/engine#20980) * 6a6c23a Roll Skia from c0d3495e1ee2 to cf1a4f50121f (6 revisions) (flutter-team-archive/engine#21026) * 716dce0 Android 30r3 (flutter-team-archive/engine#21025) * 7431070 Roll Dart SDK from 33b6c95936e0 to a2c9cae4dcd8 (1 revision) (flutter-team-archive/engine#21027) * cef383d Roll Skia from cf1a4f50121f to 04b9443274cf (2 revisions) (flutter-team-archive/engine#21028) * cf8c6b8 Update web lerpDouble to match C++ behaviour (flutter-team-archive/engine#21010) * 6866675 Roll Skia from 04b9443274cf to b8ae7fa12aa0 (1 revision) (flutter-team-archive/engine#21030) * c538f40 Roll Dart SDK from a2c9cae4dcd8 to ffbfa2000435 (1 revision) (flutter-team-archive/engine#21031) * 89d34b0 Roll Skia from b8ae7fa12aa0 to 445c8ebcb710 (1 revision) (flutter-team-archive/engine#21032) * 7766d2e Roll Fuchsia Mac SDK from TyNHQXzNU... to Phn3nF_BJ... (flutter-team-archive/engine#21034) * e3de8d0 Roll Fuchsia Linux SDK from coVjRTWSf... to eBus_y4DN... (flutter-team-archive/engine#21035) * beb7df5 Roll Skia from 445c8ebcb710 to f9d5940fef55 (3 revisions) (flutter-team-archive/engine#21037) * f3a17b6 Roll Skia from f9d5940fef55 to 81c6d6eeb4cf (1 revision) (flutter-team-archive/engine#21038) * bbcc495 Roll Dart SDK from ffbfa2000435 to 2e838b7b4503 (2 revisions) (flutter-team-archive/engine#21039) * 61062fd Roll Skia from 81c6d6eeb4cf to 81606b5d9774 (5 revisions) (flutter-team-archive/engine#21041) * f7c7b41 Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#20895)" (flutter-team-archive/engine#21043)

Enable lazy-async-stacks by-default in all modes (Take 3)

1e681da

googlebot added the cla: yes label Aug 31, 2020

auto-assign Bot requested a review from gaaclarke August 31, 2020 06:43

mkustermann approved these changes Sep 3, 2020

View reviewed changes

zanderso approved these changes Sep 3, 2020

View reviewed changes

mkustermann merged commit 575a519 into flutter-team-archive:master Sep 7, 2020

engine-flutter-autoroll mentioned this pull request Sep 8, 2020

Roll Engine from d1d848e8421e to 09a5bf7acf44 (13 revisions) flutter/flutter#65407

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

b06c6de

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 8, 2020

Roll Engine from d1d848e8421e to 808bb859a4ff (15 revisions) flutter/flutter#65420

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

cfcebb4

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 8, 2020

Roll Engine from d1d848e8421e to f0fb74b8fb52 (19 revisions) flutter/flutter#65428

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

c1fa38f

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 8, 2020

Roll Engine from d1d848e8421e to 74310709fc3e (22 revisions) flutter/flutter#65431

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

4c3d442

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to cf8c6b8ba1d3 (24 revisions) flutter/flutter#65436

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

6a90af8

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to 686667591c4d (25 revisions) flutter/flutter#65438

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

f6d33a8

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to c538f40d3610 (26 revisions) flutter/flutter#65445

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

4115d82

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to 89d34b0f38b6 (27 revisions) flutter/flutter#65452

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

ddfcf5c

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to e3de8d0f15d8 (29 revisions) flutter/flutter#65457

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

50caa59

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to beb7df50609c (30 revisions) flutter/flutter#65470

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

488d163

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to f3a17b63d0fb (31 revisions) flutter/flutter#65476

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

46de89c

…utter-team-archive/engine#20895)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to bbcc495b1391 (32 revisions) flutter/flutter#65479

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

eef4272

…utter-team-archive/engine#20895)

zanderso added a commit that referenced this pull request Sep 9, 2020

Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#2…

d2cef5e

…0895)" This reverts commit 575a519.

zanderso mentioned this pull request Sep 9, 2020

Revert "Enable lazy-async-stacks by-default in all modes (Take 3)" #21043

Merged

zanderso added a commit that referenced this pull request Sep 9, 2020

Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#2…

f7c7b41

…0895)" (#21043) This reverts commit 575a519.

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to f7c7b41f0a0c (34 revisions) flutter/flutter#65492

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (fl…

e1609b3

…utter-team-archive/engine#20895)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable lazy-async-stacks by-default in all modes (Take 3)#20895

Enable lazy-async-stacks by-default in all modes (Take 3)#20895
mkustermann merged 1 commit into
masterfrom
unknown repository

ghost commented Aug 31, 2020

Uh oh!

ghost commented Sep 3, 2020

Uh oh!

zanderso left a comment

Uh oh!

mkustermann commented Sep 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ghost commented Aug 31, 2020

Uh oh!

ghost commented Sep 3, 2020

Uh oh!

zanderso left a comment

Choose a reason for hiding this comment

Uh oh!

mkustermann commented Sep 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants