This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert external size changes to Picture#20950
Merged
dnfield merged 1 commit intoSep 2, 2020
Merged
Conversation
Contributor
Author
|
A trivial example of how this could go wrong: Path mySpecialPath;
void main() {
mySpecialPath = Path()..lineTo(....); // etc.
return runApp(MaterialApp(home: SomeWidgetThatAnimatesAndDrawsAPath(path: mySpecialPath);
}Every frame pumped by that animating widget will generate a new picture that references the path. The Dart VM will incorrectly think that collecting the picture will free the path memory, when it will not. With a sufficiently large path (e.g. thousands of lines/curves/whatever), this will result in very heavy GC for no effect. |
8 tasks
zanderso
approved these changes
Sep 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2020
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 3, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2020
flar
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 3, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971) * 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter-team-archive/engine#20973) * 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter-team-archive/engine#20974) * 3f05b52 Always set the callback during Rasterizer setup (flutter-team-archive/engine#20976)
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971)
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971) * 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter-team-archive/engine#20973) * 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter-team-archive/engine#20974) * 3f05b52 Always set the callback during Rasterizer setup (flutter-team-archive/engine#20976)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned out to be a mistake.
These objects can be retained and drawn in multiple pictures, and in fact that happens often enough with images that that part has already been reverted (#20673).