Revert "Adds fuchsia node roles to accessibility bridge updates." by flar · Pull Request #20936 · flutter-team-archive/engine

flar · 2020-09-02T04:08:42Z

Reverts #20385

This test was causing the following framework test failures for the engine roller:

00:18 +98 ~1: /tmp/flutter sdk/packages/flutter_test/test/matchers_test.dart: matchesSemanticsData Can match all semantics flags and actions                                                           
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure object was thrown running a test:
  Expected: has semantics with actions: [
            SemanticsAction:SemanticsAction.tap,
            SemanticsAction:SemanticsAction.longPress,
            SemanticsAction:SemanticsAction.scrollLeft,
            SemanticsAction:SemanticsAction.scrollRight,
            SemanticsAction:SemanticsAction.scrollUp,
            SemanticsAction:SemanticsAction.scrollDown,
            SemanticsAction:SemanticsAction.increase,
            SemanticsAction:SemanticsAction.decrease,
            SemanticsAction:SemanticsAction.showOnScreen,
            SemanticsAction:SemanticsAction.moveCursorForwardByCharacter,
            SemanticsAction:SemanticsAction.moveCursorBackwardByCharacter,
            SemanticsAction:SemanticsAction.setSelection,
            SemanticsAction:SemanticsAction.copy,
            SemanticsAction:SemanticsAction.cut,
            SemanticsAction:SemanticsAction.paste,
            SemanticsAction:SemanticsAction.didGainAccessibilityFocus,
            SemanticsAction:SemanticsAction.didLoseAccessibilityFocus,
            SemanticsAction:SemanticsAction.customAction,
            SemanticsAction:SemanticsAction.dismiss,
            SemanticsAction:SemanticsAction.moveCursorForwardByWord,
            SemanticsAction:SemanticsAction.moveCursorBackwardByWord
          ] with flags: [
            SemanticsFlag:SemanticsFlag.hasCheckedState,
            SemanticsFlag:SemanticsFlag.isChecked,
            SemanticsFlag:SemanticsFlag.isSelected,
            SemanticsFlag:SemanticsFlag.isButton,
            SemanticsFlag:SemanticsFlag.isLink,
            SemanticsFlag:SemanticsFlag.isTextField,
            SemanticsFlag:SemanticsFlag.isReadOnly,
            SemanticsFlag:SemanticsFlag.isFocused,
            SemanticsFlag:SemanticsFlag.isFocusable,
            SemanticsFlag:SemanticsFlag.hasEnabledState,
            SemanticsFlag:SemanticsFlag.isEnabled,
            SemanticsFlag:SemanticsFlag.isInMutuallyExclusiveGroup,
            SemanticsFlag:SemanticsFlag.isHeader,
            SemanticsFlag:SemanticsFlag.isObscured,
            SemanticsFlag:SemanticsFlag.namesRoute,
            SemanticsFlag:SemanticsFlag.scopesRoute,
            SemanticsFlag:SemanticsFlag.isHidden,
            SemanticsFlag:SemanticsFlag.isImage,
            SemanticsFlag:SemanticsFlag.isLiveRegion,
            SemanticsFlag:SemanticsFlag.hasToggledState,
            SemanticsFlag:SemanticsFlag.isToggled,
            SemanticsFlag:SemanticsFlag.hasImplicitScrolling
          ] with rect: Rect.fromLTRB(0.0, 0.0, 10.0, 10.0) with size: Size(10.0, 10.0) with
elevation: 3.0 with thickness: 4.0 with platformViewId: 105 with maxValueLength: 15 with
currentValueLength: 10 with custom actions: [CustomSemanticsAction(7, label:test, hint:null,
action:null)]
  Actual: _FakeSemanticsNode:<_FakeSemanticsNode#1(Rect.fromLTRB(0.0, 0.0, 0.0, 0.0), invisible)>
   Which: flags were: [hasCheckedState, isChecked, isSelected, isButton, isTextField, isFocused,
hasEnabledState, isEnabled, isInMutuallyExclusiveGroup, isHeader, isObscured, scopesRoute,
namesRoute, isHidden, isImage, isLiveRegion, hasToggledState, isToggled, hasImplicitScrolling,
isReadOnly, isFocusable, isLink, isSlider]
When the exception was thrown, this was the stack:
#4      main.<anonymous closure>.<anonymous closure> (file:///tmp/flutter%20sdk/packages/flutter_test/test/matchers_test.dart:565:7)
#5      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:146:29)
<asynchronous suspension>
#6      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart)
#7      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:784:19)
<asynchronous suspension>
#10     TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:764:14)
#11     AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1173:24)
#12     FakeAsync.run.<anonymous closure>.<anonymous closure> (package:fake_async/fake_async.dart:178:54)
#17     withClock (package:clock/src/default.dart:48:10)
#18     FakeAsync.run.<anonymous closure> (package:fake_async/fake_async.dart:178:22)
#23     FakeAsync.run (package:fake_async/fake_async.dart:178:7)
#24     AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1170:15)
#25     testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:138:24)
#26     Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:175:19)
<asynchronous suspension>
#27     Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart)
#32     Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:173:13)
#33     Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:231:15)
#38     Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:228:5)
#39     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:383:17)
<asynchronous suspension>
#40     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart)
#45     Invoker._onRun.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:370:9)
#46     Invoker._guardIfGuarded (package:test_api/src/backend/invoker.dart:415:15)
#47     Invoker._onRun.<anonymous closure> (package:test_api/src/backend/invoker.dart:369:7)
#54     Invoker._onRun (package:test_api/src/backend/invoker.dart:368:11)
#55     LiveTestController.run (package:test_api/src/backend/live_test_controller.dart:153:11)
#56     RemoteListener._runLiveTest.<anonymous closure> (package:test_api/src/remote_listener.dart:256:16)
#61     RemoteListener._runLiveTest (package:test_api/src/remote_listener.dart:255:5)
#62     RemoteListener._serializeTest.<anonymous closure> (package:test_api/src/remote_listener.dart:208:7)
#80     _GuaranteeSink.add (package:stream_channel/src/guarantee_channel.dart:125:12)
#81     new _MultiChannel.<anonymous closure> (package:stream_channel/src/multi_channel.dart:159:31)
#85     CastStreamSubscription._onData (dart:_internal/async_cast.dart:85:11)
#119    new _WebSocketImpl._fromSocket.<anonymous closure> (dart:_http/websocket_impl.dart:1145:21)
#127    _WebSocketProtocolTransformer._messageFrameEnd (dart:_http/websocket_impl.dart:338:23)
#128    _WebSocketProtocolTransformer.add (dart:_http/websocket_impl.dart:232:46)
#138    _Socket._onData (dart:io-patch/socket_patch.dart:2044:41)
#147    new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1580:33)
#148    _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1076:14)
(elided 111 frames from dart:async and package:stack_trace)
This was caught by the test expectation on the following line:
  file:///tmp/flutter%20sdk/packages/flutter_test/test/matchers_test.dart line 565
The test description was:
  Can match all semantics flags and actions

)" This reverts commit 58a6207.

flar · 2020-09-02T04:09:57Z

This was verified by running the tests in question on the indicated commit and the previous commit.

flar · 2020-09-02T04:21:00Z

Squashing and merging before tests complete to help the engine go green.

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971)

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971) * 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter-team-archive/engine#20973) * 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter-team-archive/engine#20974) * 3f05b52 Always set the callback during Rasterizer setup (flutter-team-archive/engine#20976)

* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971)

* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter-team-archive/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter-team-archive/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter-team-archive/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter-team-archive/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter-team-archive/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter-team-archive/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter-team-archive/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter-team-archive/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter-team-archive/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter-team-archive/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter-team-archive/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter-team-archive/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter-team-archive/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter-team-archive/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter-team-archive/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter-team-archive/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter-team-archive/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter-team-archive/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter-team-archive/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter-team-archive/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter-team-archive/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter-team-archive/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter-team-archive/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter-team-archive/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter-team-archive/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter-team-archive/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter-team-archive/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter-team-archive/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter-team-archive/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter-team-archive/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter-team-archive/engine#20754) * c700479 Revert external size changes to Picture (flutter-team-archive/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter-team-archive/engine#20955) * 80f4481 renaming e2e tests to integration (flutter-team-archive/engine#20954) * 61e057a Clear GL context before Gr context (flutter-team-archive/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter-team-archive/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter-team-archive/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter-team-archive/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter-team-archive/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter-team-archive/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter-team-archive/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter-team-archive/engine#20971) * 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter-team-archive/engine#20973) * 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter-team-archive/engine#20974) * 3f05b52 Always set the callback during Rasterizer setup (flutter-team-archive/engine#20976)

…es. (flutter-team-archive#20385)" (flutter-team-archive#20936)" This reverts commit 96efe39.

…es. (#20385)" (#20936)" (#21367) This reverts commit 96efe39.

Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385

8648198

)" This reverts commit 58a6207.

googlebot added the cla: yes label Sep 2, 2020

GaryQian approved these changes Sep 2, 2020

View reviewed changes

flar merged commit 96efe39 into master Sep 2, 2020

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to 5585ed99039e (22 revisions) flutter/flutter#65075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

802567a

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to 615e66801442 (25 revisions) flutter/flutter#65105

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

7ff767a

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to ca989b8ae004 (26 revisions) flutter/flutter#65107

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

da6354f

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to 873c007934a4 (28 revisions) flutter/flutter#65110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

f6c53ee

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to d761629cb13e (29 revisions) flutter/flutter#65117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

4cbe456

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to f6920dae5509 (30 revisions) flutter/flutter#65122

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

f7575ad

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to 634e499bcc65 (31 revisions) flutter/flutter#65130

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

9d3149a

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 5a2db338e148 (37 revisions) flutter/flutter#65151

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

083a346

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to efb339f3000d (38 revisions) flutter/flutter#65154

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

1561dc8

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 58d5132e07e9 (39 revisions) flutter/flutter#65155

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

667024f

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 3729fdb7936d (40 revisions) flutter/flutter#65161

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

38d2766

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 40fe7f3597b6 (41 revisions) flutter/flutter#65172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

c4f82ea

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to e979c29a2a50 (42 revisions) flutter/flutter#65178

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

38048f6

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 3f05b521b939 (45 revisions) flutter/flutter#65196

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

96efe39 Revert "Adds fuchsia node roles to accessibility bridge updat…

807c08c

…es. (flutter#20385)" (flutter-team-archive/engine#20936)

abrush21 added a commit to abrush21/engine that referenced this pull request Sep 23, 2020

Revert "Revert "Adds fuchsia node roles to accessibility bridge updat…

e855b7a

…es. (flutter-team-archive#20385)" (flutter-team-archive#20936)" This reverts commit 96efe39.

abrush21 mentioned this pull request Sep 23, 2020

Reland: Adds fuchsia node roles to accessibility bridge updat… #21367

Merged

12 tasks

chunhtai pushed a commit that referenced this pull request Sep 25, 2020

Revert "Revert "Adds fuchsia node roles to accessibility bridge updat…

de5f2b4

…es. (#20385)" (#20936)" (#21367) This reverts commit 96efe39.

cbracken deleted the revert-20385-a11y-roles-2 branch May 10, 2022 21:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "Adds fuchsia node roles to accessibility bridge updates."#20936

Revert "Adds fuchsia node roles to accessibility bridge updates."#20936
flar merged 1 commit into
masterfrom
revert-20385-a11y-roles-2

flar commented Sep 2, 2020

Uh oh!

flar commented Sep 2, 2020

Uh oh!

flar commented Sep 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

flar commented Sep 2, 2020

Uh oh!

flar commented Sep 2, 2020

Uh oh!

flar commented Sep 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants