Skip to content

Breaking change page for ColorScheme change #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parlough merged 17 commits into from
Mar 27, 2024
Merged

Breaking change page for ColorScheme change #10274

parlough merged 17 commits into from
Mar 27, 2024

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Mar 13, 2024

This PR is to add a breaking change page for the recent ColorScheme change(flutter/flutter#142654, flutter/flutter#144273 and flutter/flutter#144805).

Presubmit checklist

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 13, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6ee1da8):

https://flutter-docs-prod--pr10274-color-scheme-breaking-chang-km5e502j.web.app

sfshaza2
sfshaza2 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@QuncCccccc QuncCccccc requested a review from HansMuller March 13, 2024 19:30
@QuncCccccc QuncCccccc marked this pull request as ready for review March 13, 2024 19:30
HansMuller
HansMuller reviewed Mar 13, 2024
View reviewed changes
@sfshaza2
Copy link
Contributor

sfshaza2 commented Mar 14, 2024

/gcbrun

HansMuller
HansMuller reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we say what new colors to use instead of background, onBackground, and surfaceVariant?

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Mar 14, 2024

Shouldn't we say what new colors to use instead of background, onBackground, and surfaceVariant?

Ah thanks for pointing this out! Yes, we should. I will add this part later today!

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Mar 25, 2024

Shouldn't we say what new colors to use instead of background, onBackground, and surfaceVariant?

Just added a migration guide for these colors!

parlough
parlough approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

I updated a few broken links and link definitions :)

sfshaza2
sfshaza2 reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor grammatical fixes, otherwise, this looks really good!

sfshaza2
sfshaza2 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Mar 26, 2024

A few minor grammatical fixes, otherwise, this looks really good!

Thanks a lot for the help😃!

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Mar 26, 2024

Looks good to me. Thanks!

I updated a few broken links and link definitions :)

Got it! Thanks!!

@parlough parlough merged commit 9f92006 into main Mar 27, 2024
@parlough parlough deleted the color_scheme_breaking_change branch March 27, 2024 14:43
atsansone pushed a commit to atsansone/website that referenced this pull request Apr 5, 2024
@QuncCccccc @parlough @sfshaza2
Breaking change page for ColorScheme change (flutter#10274)
3fb1024 
This PR is to add a breaking change page for the recent ColorScheme
change(flutter/flutter#142654,
flutter/flutter#144273 and
flutter/flutter#144805).

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@parlough parlough parlough approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@atsansone atsansone Awaiting requested review from atsansone

@MaryaBelanger MaryaBelanger Awaiting requested review from MaryaBelanger

+1 more reviewer

@HansMuller HansMuller HansMuller left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@QuncCccccc @flutter-website-bot @sfshaza2 @domesticmouse @HansMuller @parlough