Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" #144273

QuncCccccc · 2024-02-27T23:15:13Z

The Golden diffs have been approved before, it should be safe to land this change now:)

…lor add-…" This reverts commit 2eee0b5.

flutter-dashboard · 2024-02-27T23:56:11Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #144273 at sha edaacd7

Piinks · 2024-02-28T00:04:30Z

Can you push another commit without a force push so I can double check the goldens?

…38586bab08a36db1092

QuncCccccc · 2024-02-28T00:19:56Z

Can you push another commit without a force push so I can double check the goldens?

Yes! Just pushed some empty commits. Since there was a conflict, so after I solved it, pushed another one.

Piinks · 2024-02-28T17:51:06Z

Ah thanks! Looks like Gold is good here, is the Google testing failure expected?

QuncCccccc · 2024-02-28T17:53:14Z

Ah thanks! Looks like Gold is good here, is the Google testing failure expected?

Yes! Google testing failures are expected. I sent cl/609608958 for teams to review and have got all LGTMs:)

Piinks

LGTM!

Piinks · 2024-02-28T21:49:43Z

Oh weird, the github UI glitched when I submitted.

QuncCccccc · 2024-02-28T21:56:40Z

LGTM!

Thanks!

…or add-ons - Part 2" (flutter/flutter#144273)

flutter/flutter@d00bfe8...e92bca3 2024-02-29 leroux_bruno@yahoo.fr [flutter_tools] Update external link in Android manifest template (flutter/flutter#144302) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 232217f39c3c to d068d980f952 (1 revision) (flutter/flutter#144369) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e1876141be8 to 232217f39c3c (1 revision) (flutter/flutter#144366) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 61510db94a1c to 9e1876141be8 (1 revision) (flutter/flutter#144362) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10331db8f748 to 61510db94a1c (5 revisions) (flutter/flutter#144355) 2024-02-29 jmccandless@google.com Docs on the interaction between Shortcuts and text input (flutter/flutter#144328) 2024-02-29 dnfield@google.com Use robolectric/AndroidJUnit4 for integration test tests (flutter/flutter#144348) 2024-02-29 31859944+LongCatIsLooong@users.noreply.github.com Reland "Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207)" (flutter/flutter#144330) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 455c814fe5de to 10331db8f748 (7 revisions) (flutter/flutter#144345) 2024-02-29 dkwingsmt@users.noreply.github.com ReportTiming callback should record the sendFrameToEngine when it was scheduled (flutter/flutter#144212) 2024-02-29 katelovett@google.com Disable flaky golden file test (flutter/flutter#144351) 2024-02-28 jmccandless@google.com Mention SelectionArea in SelectableText docs (flutter/flutter#143784) 2024-02-28 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.0 to 6.0.1 (flutter/flutter#144344) 2024-02-28 36861262+QuncCccccc@users.noreply.github.com Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#144273) 2024-02-28 72562119+tgucio@users.noreply.github.com Remove irrelevant comment in TextPainter (flutter/flutter#144308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Hixie · 2024-03-05T23:20:59Z

This caused an application I'm working on to change color, from:

...to:

...and I can't figure out what value to pass to ColorScheme.fromSeed to get the old colors.

Was that intentional?

The new [`ColorScheme` change](flutter/flutter#144273) causes some golden failures in Cocoon. This PR is to update them.

flutter/flutter@d00bfe8...e92bca3 2024-02-29 leroux_bruno@yahoo.fr [flutter_tools] Update external link in Android manifest template (flutter/flutter#144302) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 232217f39c3c to d068d980f952 (1 revision) (flutter/flutter#144369) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e1876141be8 to 232217f39c3c (1 revision) (flutter/flutter#144366) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 61510db94a1c to 9e1876141be8 (1 revision) (flutter/flutter#144362) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10331db8f748 to 61510db94a1c (5 revisions) (flutter/flutter#144355) 2024-02-29 jmccandless@google.com Docs on the interaction between Shortcuts and text input (flutter/flutter#144328) 2024-02-29 dnfield@google.com Use robolectric/AndroidJUnit4 for integration test tests (flutter/flutter#144348) 2024-02-29 31859944+LongCatIsLooong@users.noreply.github.com Reland "Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207)" (flutter/flutter#144330) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 455c814fe5de to 10331db8f748 (7 revisions) (flutter/flutter#144345) 2024-02-29 dkwingsmt@users.noreply.github.com ReportTiming callback should record the sendFrameToEngine when it was scheduled (flutter/flutter#144212) 2024-02-29 katelovett@google.com Disable flaky golden file test (flutter/flutter#144351) 2024-02-28 jmccandless@google.com Mention SelectionArea in SelectableText docs (flutter/flutter#143784) 2024-02-28 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.0 to 6.0.1 (flutter/flutter#144344) 2024-02-28 36861262+QuncCccccc@users.noreply.github.com Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#144273) 2024-02-28 72562119+tgucio@users.noreply.github.com Remove irrelevant comment in TextPainter (flutter/flutter#144308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter#138521 (reland PR: flutter/flutter#144273) is merged. Re-enable cocoon.

The new [`ColorScheme` change](flutter/flutter#144273) causes some golden failures in Cocoon. This PR is to update them.

This PR is to add a breaking change page for the recent ColorScheme change(flutter/flutter#142654, flutter/flutter#144273 and flutter/flutter#144805). --------- Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

…or add-ons - Part 2" (flutter/flutter#144273)

himotou · 2024-05-22T03:58:06Z

I have some questions about the ColorScheme upgrade.
In the latest version, I saw that background and onBackground were removed. In my project, I use it to define the background color of the page or card, without using surface and onSurface. Because onSurface is used in the system's built-in long-press popup option.
There are some other similar situations, but not many. For such situations, I generally avoid using this attribute.
In the latest version, background and onBackground have been removed. For me, I can only use surface and onSurface, but onSurface is occupied by the system. Do you have any good suggestions for this problem?

QuncCccccc · 2024-05-22T17:04:32Z

I have some questions about the ColorScheme upgrade. In the latest version, I saw that background and onBackground were removed. In my project, I use it to define the background color of the page or card, without using surface and onSurface. Because onSurface is used in the system's built-in long-press popup option. There are some other similar situations, but not many. For such situations, I generally avoid using this attribute. In the latest version, background and onBackground have been removed. For me, I can only use surface and onSurface, but onSurface is occupied by the system. Do you have any good suggestions for this problem?

Hi! We can add color roles by using ThemeExtension! Here's an example showing how we can add more colors in theme:)

Update:
Sorry, I just noticed I didn't attach the example link... Here it is! https://api.flutter.dev/flutter/material/ThemeExtension-class.html#material.ThemeExtension.1

This PR is to fix #2289 and add newly added `ColorScheme` roles since flutter/flutter#144273 --------- Co-authored-by: Parker Lougheed <parlough@gmail.com>

himotou · 2024-05-23T00:56:48Z

I have some questions about the ColorScheme upgrade. In the latest version, I saw that background and onBackground were removed. In my project, I use it to define the background color of the page or card, without using surface and onSurface. Because onSurface is used in the system's built-in long-press popup option. There are some other similar situations, but not many. For such situations, I generally avoid using this attribute. In the latest version, background and onBackground have been removed. For me, I can only use surface and onSurface, but onSurface is occupied by the system. Do you have any good suggestions for this problem?

Hi! We can add color roles by using ThemeExtension! Here's an example showing how we can add more colors in theme:)

Great, thank you very much!

Revert "Reverts "Reland - Introduce tone-based surfaces and accent co…

edaacd7

…lor add-…" This reverts commit 2eee0b5.

QuncCccccc changed the title ~~Reland - Introduce tone-based surfaces and accent color add-ons - Part 2~~ Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" Feb 27, 2024

QuncCccccc requested a review from Piinks February 27, 2024 23:41

flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 27, 2024

QuncCccccc and others added 4 commits February 27, 2024 16:12

Trigger tests

6a8512a

Merge branch 'master' into revert-144262-revert_871d59221c67c148264ca…

1ff237c

…38586bab08a36db1092

Trigger tests

307efc4

Trigger another test after solving conflicts

3df5f97

Piinks requested changes Feb 28, 2024

View reviewed changes

Piinks approved these changes Feb 28, 2024

View reviewed changes

QuncCccccc merged commit 0d8eafb into master Feb 28, 2024

QuncCccccc deleted the revert-144262-revert_871d59221c67c148264ca38586bab08a36db1092 branch February 28, 2024 21:55

engine-flutter-autoroll mentioned this pull request Feb 29, 2024

Roll Flutter from d00bfe820eef to e92bca3ff5d2 (15 revisions) flutter/packages#6227

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 29, 2024

0d8eafb Reland "Reland - Introduce tone-based surfaces and accent col…

1deec78

…or add-ons - Part 2" (flutter/flutter#144273)

Hixie mentioned this pull request Mar 5, 2024

Button colors generated from ColorScheme.fromSeed changed #144649

Closed

QuncCccccc mentioned this pull request Mar 6, 2024

Update goldens flutter/cocoon#3549

Merged

8 tasks

auto-submit bot pushed a commit to flutter/cocoon that referenced this pull request Mar 6, 2024

Update goldens (#3549)

b351a5b

The new [`ColorScheme` change](flutter/flutter#144273) causes some golden failures in Cocoon. This PR is to update them.

QuncCccccc mentioned this pull request Mar 6, 2024

Enable cocoon test flutter/tests#347

Merged

8 tasks

auto-submit bot pushed a commit to flutter/tests that referenced this pull request Mar 7, 2024

Enable cocoon test (#347)

24d67a2

flutter/flutter#138521 (reland PR: flutter/flutter#144273) is merged. Re-enable cocoon.

sealesj pushed a commit to sealesj/cocoon that referenced this pull request Mar 7, 2024

Update goldens (flutter#3549)

6415700

The new [`ColorScheme` change](flutter/flutter#144273) causes some golden failures in Cocoon. This PR is to update them.

QuncCccccc mentioned this pull request Mar 13, 2024

Breaking change page for ColorScheme change flutter/website#10274

Merged

3 tasks

QuncCccccc mentioned this pull request Mar 25, 2024

Secondary TabBar indicator height token is missing #124965

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

0d8eafb Reland "Reland - Introduce tone-based surfaces and accent col…

d8ba6eb

…or add-ons - Part 2" (flutter/flutter#144273)

QuncCccccc mentioned this pull request May 21, 2024

Update ColorScheme to show the newly added color roles flutter/samples#2299

Merged

5 tasks

QuncCccccc mentioned this pull request May 31, 2024

Add neutral Material themes #139338

Closed

2 tasks

Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" #144273

Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" #144273

Uh oh!

Conversation

QuncCccccc commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Feb 27, 2024

Uh oh!

Piinks commented Feb 28, 2024

Uh oh!

QuncCccccc commented Feb 28, 2024

Uh oh!

Piinks commented Feb 28, 2024

Uh oh!

QuncCccccc commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Feb 28, 2024

Uh oh!

QuncCccccc commented Feb 28, 2024

Uh oh!

Hixie commented Mar 5, 2024

Uh oh!

himotou commented May 22, 2024

Uh oh!

QuncCccccc commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

himotou commented May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

QuncCccccc commented Feb 27, 2024 •

edited

Loading

QuncCccccc commented Feb 28, 2024 •

edited

Loading

QuncCccccc commented May 22, 2024 •

edited

Loading