This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Pre-emptively ignore prefer_const_constructor warning. #4550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will preemptively ignore the prefer_const_constructor warning to make it possible to migrate the webview_flutter_platform_interface without breaking changes to the more strict analysis_options.yaml (see issue flutter/flutter#76229). A cleanup issue also exist as a reminder to remove the temporary ignore statements and can be found here: flutter/flutter#94311)
11 tasks
Contributor
|
Did you need the "no version change", or was that pre-emptive? This should have passed the version check without that due to the files touched; if it failed that's a bug. |
Contributor
Author
|
No I added it preemptively. I did receive the "No CHANGELOG" warning though (which was fixed by added the right description). |
Contributor
|
Great, sounds like it worked as intended then; the automatic exemptions are just for the version change, not the CHANGLOG (since that's the general policy we're using, at least for now). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 29, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will pre-emptively ignore the
prefer_const_constructorwarning to make it possible to migrate the webview_flutter_platform_interface without breaking changes to the more strict analysis_options.yaml (see issue flutter/flutter#76229).A cleanup issue also exist as a reminder to remove the temporary ignore statements and can be found here: flutter/flutter#94311
No version change: this is a temporary change and only necessary to land on master not to break the build when merging #4549. These changes will be undone as part of flutter/flutter#94311 as soon as #4549 lands.
No CHANGELOG change: this is a temporary change and only necessary to land on master not to break the build when merging #4549. These changes will be undone as part of flutter/flutter#94311 as soon as #4549 lands.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).