Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] allow camera plugin to be installed when android api < 21 #1482

Closed
jaumard wants to merge 1 commit into from
Closed

[camera] allow camera plugin to be installed when android api < 21 #1482

jaumard wants to merge 1 commit into from

Conversation

@jaumard
Copy link
Contributor

@jaumard jaumard commented Apr 11, 2019 •
edited
Loading

Description

Currently camera plugin is working for API 21, but flutter is since 16, so camera should be able to be installed on API 16 even if it doesn't work. That will allow developers to target API 16 and just hide the camera features for API 21 or more.

Related Issues

fix flutter/flutter#30854

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jaumard jaumard force-pushed the feature/camera_api_16_installation branch 2 times, most recently from 1b2d5dd to db05658 Compare April 11, 2019 09:44
@jaumard
Copy link
Contributor Author

jaumard commented Apr 11, 2019

Hey @bparrishMines ! surprise to see you as reviewer ^^ didn't expect this :)
I looked https://github.com/bparrishMines/mlkit_demo and manage to create a package for camera live stream with ml vision recognition (https://github.com/santetis/flutter_camera_ml_vision)

I need this PR because my app target api16+ :) and it prevent us to release our app in production right now as we can't compile

publishable build are not accurate :( it didn't check the pubspec of the example app, only the one of the plugin itself... that's why it's failing. Do I remove my api 16 check ? it will make the build green but will not show how to prevent usage on this api.

@jaumard jaumard force-pushed the feature/camera_api_16_installation branch from db05658 to 301f85e Compare April 12, 2019 08:49
@bparrishMines bparrishMines mentioned this pull request Apr 17, 2019
Closed
@jaumard jaumard mentioned this pull request Apr 29, 2019
Closed
@bparrishMines bparrishMines mentioned this pull request May 14, 2019
Merged
12 tasks
@bparrishMines
Copy link
Contributor

bparrishMines commented May 14, 2019

Hi @jaumard,

Thanks for the contribution!

After looking at your PR and looking into the problem, I tried to find a solution that would involve minimum code. For now, we are trying to avoid moving the Camera code into a separate file. I created another PR that should solve this problem without moving as much code.

#1598

If you get the chance, let me know if it works for you.

@jaumard
Copy link
Contributor Author

jaumard commented May 14, 2019

hey @bparrishMines

I tried at first to not move any code, but it still wasn't working. Probably didn't do it right ^^
Just tested your PR and I got this:

08:57:14.255 15 info flutter.tools > Android dependency 'androidx.exifinterface:exifinterface' has different version for the compile (1.0.0-rc01) and runtime (1.0.0) classpath. You should manually set the same version via DependencyResolution

But once I forced a version it was working great thanks ! can close this one

@jaumard jaumard closed this May 14, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@tolo @collinjackson
[firebase_storage] Added error handling to writeToFile (flutter#1482)
50e84ed 
* [firebase_storage] Added error handling to writeToFile (StorageFileDownloadTask) - see flutter#1418.

* Added error handling for integration testing of writeToFile.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@mklim mklim Awaiting requested review from mklim

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Camera Plugin] should be installable on api 16+ even if it will not work

3 participants

@jaumard @bparrishMines @googlebot