This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_crashlytics] Rely on firebase_core to set up Firebase Analytics dependency #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kroikie
approved these changes
Apr 4, 2019
Contributor
|
@paulcbetts Thanks for the fix! |
|
@kroikie curious if it's possible to load a specific sha from the mono repo? also, how do plugins normally get rolled to a new release? e.g. this does not work firebase_crashlytics:
git:
url: https://github.com/flutter/plugins.git
ref: 25a60b380034e022cf8911d1b3864255786b5574 |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…tics dependency (flutter#1418) * Rely on firebase_core to set up Firebase Analytics dependency Fixes flutter/flutter#30037
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* [firebase_storage] Added error handling to writeToFile (StorageFileDownloadTask) - see flutter#1418. * Added error handling for integration testing of writeToFile.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rely on firebase_core to set up Firebase Analytics dependency instead of setting it ourselves. This stops firebase_crashlytics from conflicting with other Firebase plugins on Android.
Related Issues
Fixes flutter/flutter#30037
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).All existing and new tests are passing.I updated/added relevant documentation (doc comments with///).The analyzer (flutter analyze) does not report any problems on my PR.I read and followed the Flutter Style Guide.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?