[material_ui] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests"#11983
[material_ui] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests"#11983MarlonJD wants to merge 3 commits into
Conversation
8c3a514 to
334905e
Compare
There was a problem hiding this comment.
Code Review
This pull request removes the @Skip annotations from several test files, including checkbox_test.dart, radio_test.dart, range_slider_test.dart, slider_test.dart, and toggle_buttons_test.dart. It also updates the import path of semantics_tester.dart from a relative parent directory to a local path, and reformats several test blocks in slider_test.dart. The review feedback points out a grammatical typo in one of the test descriptions in slider_test.dart and suggests correcting 'appear' to 'appears'.
|
A note on why these files moved out of I also verified the enabled tests locally with:\n\n That passed with 304 tests. |
334905e to
29324a4
Compare
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks so much for porting this PR so quickly! Let me know if there's anything in the porting instructions in flutter/flutter#188444 that could be improved.
I see there are still a bunch of formatting changes in this PR, but I'm not sure whether or not they are needed. Let's let CI run and see if it passes, if so then I think it's good.
|
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
|
Thanks! I pushed GitHub now reports the PR as mergeable, and
One possible improvement for the porting instructions: it may help to include a concrete PR title example, such as |
|
Hi @MarlonJD! Thanks a lot for your contribution! Could you help fix Linux analyze master and stable? Seems the imports need to be sorted. |
|
Fixed in Local validation:
The GitHub label/check-change gates have run; waiting for the remaining Linux analyze master/stable presubmit statuses to be scheduled/reported. |

This PR ports flutter/flutter#186670 by @MarlonJD from flutter/flutter to flutter/packages.
It moves the affected Material selection tests from material_ui's
temporarily_disabled_testsdirectory into the maintestdirectory now that their gross../widgets/semantics_tester.dartimport has been fixed to use material_ui's localsemantics_tester.dart.This follows the porting instructions in flutter/flutter#188444:
temporarily_disabled_testsfiles are moved into the main test directory after fixing the gross importValidation:
dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/slider_test.dart packages/material_ui/test/toggle_buttons_test.dartgit diff --checkflutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/slider_test.dart test/toggle_buttons_test.dartThe targeted test command passed with 304 tests.