Skip to content

[Decoupling] Port over any relevant open PRs from flutter/flutter that affect Material or Cupertino #188444

Description

@justinmc

Since Material and Cupertino are frozen in flutter/flutter, and their main code has been copied to flutter/packages in flutter/packages#11888, we should port to flutter/packages any open PR that affects the ported code.

Which PRs should be ported?

How should PRs be ported?

If possible, the easiest way may be to cherry pick the commits to flutter/packages:

  1. Cherry pick the commits from the PR into a new branch in flutter/packages. Do not include merge commits.
git remote add <author's GitHub ID> git@github.com:<author's GitHub ID>/flutter.git
git fetch <author's GitHub ID>
git cherry-pick <list of SHAs from the author's PR, excluding merge commits>
  1. Fix any conflicts and ensure that the changes ended up in the correct directories.
  2. Push your branch and open a new PR. Tag the original author.
  3. Close the old PR and leave a coment pointing to the new PR.

Some of the affected tests may be in the temporarily_disabled_tests directory of cupertino_ui or material_ui. If your change is fixing a gross import for these tests, they may be moved to the main test directory.

For an example PR, see flutter/packages#11965.

Related

Similar to #188441, which covers porting over merged PRs.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listf: cupertinoflutter/packages/flutter/cupertino repositoryf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.team-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Type

No type
No fields configured for issues without a type.

Projects

Status
No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions