Use local semantics tester in Material selection tests#186670
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the import path for semantics_tester.dart from '../widgets/semantics_tester.dart' to 'semantics_tester.dart' across several Material test files, including checkbox_test.dart, radio_test.dart, range_slider_test.dart, slider_test.dart, and toggle_buttons_test.dart. I have no feedback to provide.
|
Local verification passed for this PR: |
…n-semantics-imports
…ts' into material-selection-semantics-imports
|
Formatter-only follow-up; no logic changes. |
|
@victorsanni The latest push was formatter-only and has no logic changes. Could you please re-approve when you have a moment? |
|
Gentle follow-up: the latest push was formatter-only, and there are no failed checks besides the global tree-status. Could you please re-approve and add CICD when you get a chance? |
|
This PR is ready to be ported over to flutter/packages in the new material_ui package! This PR is also necessary for pre-release of the material_ui package. If you are unable to work on this right now, no worries! We’ll go ahead and port it over to get it landed. Your contribution is greatly appreciated. 💙 |
|
Ported this change to flutter/packages in flutter/packages#11983, following the porting instructions in #188444. Closing this flutter/flutter PR now that the material_ui port PR is ready for review. |
Part of #182636.
Switches the Material selection control test files that already have a local
semantics_tester.dartcopy from importing../widgets/semantics_tester.dartto importing the local Material test utility. This removes another small set of cross-library test utility imports ahead of the Material/Cupertino package split.Validation: