[Decoupling] Repo-wide changes#11874
Conversation
So we run repo-wide tests here and not in that giant PR.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: configuration change |
| - rfw/example | ||
| # Disables docs requirements, as it is test code. | ||
| - web_benchmarks/testing/test_app | ||
| # Use a 100 line width carried over from flutter/flutter. |
There was a problem hiding this comment.
This reason is obsolete; is there something current we can point to?
There was a problem hiding this comment.
Updated with a reference to the skipped tests.
Does that mean that I can remove the line about the 100 character line length from the analysis options in #11669 then?
There was a problem hiding this comment.
Code Review
This pull request adds allowed dependencies for material_color_utilities and clock in .repo_tool_config.yaml, and includes material_ui and cupertino_ui in script/configs/custom_analysis.yaml. Feedback recommends moving material_color_utilities to the unpinned Google-owned packages section to avoid dependency conflicts, and sorting the new entries in custom_analysis.yaml alphabetically to maintain the established order.
| # For material_ui, taken from flutter/flutter. | ||
| - material_color_utilities | ||
|
|
There was a problem hiding this comment.
Since material_color_utilities is a Google-owned package (developed by the Material Design team and used directly by Flutter), we fully trust its development and publishing process. According to the repository guidelines, it should be placed under the unpinned section (specifically under Google-owned packages around line 118) rather than the pinned section. Keeping it pinned unnecessarily restricts packages from using standard version ranges and can lead to dependency conflicts for consumers.
Please move this entry to the unpinned -> Google-owned packages section in alphabetical order.
| # Use a 100 line width carried over from flutter/flutter. | ||
| - material_ui | ||
| - cupertino_ui |
There was a problem hiding this comment.
The packages in this configuration file are sorted alphabetically. Adding material_ui and cupertino_ui at the end of the file breaks this order.
Please remove them from the end of the file and insert them in their correct alphabetical positions with their respective comments:
cupertino_uishould be placed afteranimations(around line 18).material_uishould be placed aftergo_router_builder/example(around line 26).
| - xml | ||
|
|
||
| # For material_ui, taken from flutter/flutter. | ||
| - material_color_utilities |
There was a problem hiding this comment.
Pinned runtime dependencies in published packages are very strongly discouraged. Isn't this Google-owned? If so it can do down in the section starting on line 113 and be unpinned.
There was a problem hiding this comment.
Yes this is Google owned. I've moved it.
I pinned this because it is pinned here in flutter/flutter:
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM!
This will probably hit some plugin integration test flake or something that will need re-runs to land, but then iterating on the main PR won't have that problem :)
…r#187739) flutter/packages@13b49f4...bd297cf 2026-06-09 jessiewong401@gmail.com [AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin (flutter/packages#11806) 2026-06-09 stuartmorgan@google.com [tool] Check for any Flutter SDK dependency (flutter/packages#11875) 2026-06-09 22373191+Hari-07@users.noreply.github.com [google_maps_flutter_ios_sdk9] Fix title in google maps sdk9 readme (flutter/packages#11826) 2026-06-08 jmccandless@google.com [Decoupling] Repo-wide changes (flutter/packages#11874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR makes the repo-wide changes from flutter#11669 in a smaller PR.
…r#187739) flutter/packages@13b49f4...bd297cf 2026-06-09 jessiewong401@gmail.com [AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin (flutter/packages#11806) 2026-06-09 stuartmorgan@google.com [tool] Check for any Flutter SDK dependency (flutter/packages#11875) 2026-06-09 22373191+Hari-07@users.noreply.github.com [google_maps_flutter_ios_sdk9] Fix title in google maps sdk9 readme (flutter/packages#11826) 2026-06-08 jmccandless@google.com [Decoupling] Repo-wide changes (flutter/packages#11874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR makes the repo-wide changes from #11669 in a smaller PR.