[AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin by jesswrd · Pull Request #11806 · flutter/packages

jesswrd · 2026-05-30T03:51:39Z

Migrate remaining example apps to built-in kotlin. Refactored validation checks for kotlin configs and added unit tests for example apps. Now both plugin modules and plugin example apps have checks for kotlin configs (includes built-in kotlin configs).

Fixes flutter/flutter#187325

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request updates multiple example Android applications and validation tests to upgrade Gradle to 9.1.0, the Android Gradle Plugin to 9.0.1, and Kotlin to 2.3.20. It removes the kotlin-android plugin and migrates kotlinOptions to the new kotlin compiler options block targeting JVM 17. Feedback across several files indicates that setting android.builtInKotlin and android.newDsl to false in gradle.properties will cause build failures since the kotlin-android plugin was removed. These flags should be updated to true to enable built-in Kotlin support.

gemini-code-assist · 2026-06-02T17:09:01Z

+# This builtInKotlin flag was added automatically by Flutter migrator
+android.builtInKotlin=false
+# This newDsl flag was added automatically by Flutter migrator
+android.newDsl=false


Since the goal of this pull request is to migrate the example apps to built-in Kotlin and the new DSL, these flags should be set to true. Setting them to false disables the built-in Kotlin support.

Furthermore, because kotlin-android was removed from build.gradle.kts, having android.builtInKotlin=false will cause Gradle to fail with an error like Extension with name 'kotlin' does not exist because the Kotlin plugin is never applied.

Please update this flag to true across all gradle.properties files in this PR.

# This builtInKotlin flag was added automatically by Flutter migrator android.builtInKotlin=true # This newDsl flag was added automatically by Flutter migrator android.newDsl=true

gemini-code-assist · 2026-06-02T17:09:01Z

+# This builtInKotlin flag was added automatically by Flutter migrator
+android.builtInKotlin=false
+# This newDsl flag was added automatically by Flutter migrator
+android.newDsl=false


Since the goal of this pull request is to migrate the example apps to built-in Kotlin and the new DSL, these flags should be set to true. Setting them to false disables the built-in Kotlin support.

Furthermore, because kotlin-android was removed from build.gradle.kts, having android.builtInKotlin=false will cause Gradle to fail with an error like Extension with name 'kotlin' does not exist because the Kotlin plugin is never applied.

Please update this flag to true across all gradle.properties files in this PR.

# This builtInKotlin flag was added automatically by Flutter migrator android.builtInKotlin=true # This newDsl flag was added automatically by Flutter migrator android.newDsl=true

jesswrd · 2026-06-02T17:09:13Z

@stuartmorgan-g I noticed there aren't really any existing validators for configurations like kotlinOptions{} in example plugin apps. Do you happen to know why? If there isn't an explicit reason for excluding those tests, I'm going to add them.

stuartmorgan-g · 2026-06-03T20:22:22Z

@stuartmorgan-g I noticed there aren't really any existing validators for configurations like kotlinOptions{} in example plugin apps. Do you happen to know why?

I'm pretty sure I just missed adding some validation when I was doing the Kotlin gradle migrations. As I'm sure you're well aware by now, keeping track of which things are in which variants and which ones have been validated is... nontrivial :)

flutter-dashboard · 2026-06-08T20:56:33Z

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

jesswrd · 2026-06-08T21:15:37Z

@stuartmorgan-g I noticed there aren't really any existing validators for configurations like kotlinOptions{} in example plugin apps. Do you happen to know why?

I'm pretty sure I just missed adding some validation when I was doing the Kotlin gradle migrations. As I'm sure you're well aware by now, keeping track of which things are in which variants and which ones have been validated is... nontrivial :)

@stuartmorgan-g Ah, gotcha. I added the same validations to the example app build.gradle(.kts) files. Ready for review now.

stuartmorgan-g

LGTM

…r#187739) flutter/packages@13b49f4...bd297cf 2026-06-09 jessiewong401@gmail.com [AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin (flutter/packages#11806) 2026-06-09 stuartmorgan@google.com [tool] Check for any Flutter SDK dependency (flutter/packages#11875) 2026-06-09 22373191+Hari-07@users.noreply.github.com [google_maps_flutter_ios_sdk9] Fix title in google maps sdk9 readme (flutter/packages#11826) 2026-06-08 jmccandless@google.com [Decoupling] Repo-wide changes (flutter/packages#11874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#11806) Migrate remaining example apps to built-in kotlin. Refactored validation checks for kotlin configs and added unit tests for example apps. Now both plugin modules and plugin example apps have checks for kotlin configs (includes built-in kotlin configs). Fixes flutter/flutter#187325 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…r#187739) flutter/packages@13b49f4...bd297cf 2026-06-09 jessiewong401@gmail.com [AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin (flutter/packages#11806) 2026-06-09 stuartmorgan@google.com [tool] Check for any Flutter SDK dependency (flutter/packages#11875) 2026-06-09 22373191+Hari-07@users.noreply.github.com [google_maps_flutter_ios_sdk9] Fix title in google maps sdk9 readme (flutter/packages#11826) 2026-06-08 jmccandless@google.com [Decoupling] Repo-wide changes (flutter/packages#11874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

hope this passes

d32a992

flutter-dashboard Bot added the CICD Run CI/CD label May 30, 2026

jesswrd added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels May 30, 2026

github-actions Bot removed the CICD Run CI/CD label Jun 2, 2026

jesswrd changed the title ~~[AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin~~ [WIP] [AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin Jun 2, 2026

jesswrd added the CICD Run CI/CD label Jun 2, 2026

jesswrd changed the title ~~[WIP] [AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin~~ [AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin Jun 2, 2026

jesswrd marked this pull request as ready for review June 2, 2026 17:07

jesswrd requested a review from stuartmorgan-g June 2, 2026 17:07

gemini-code-assist Bot reviewed Jun 2, 2026

View reviewed changes

Merge branch 'main' into migrate-remaining-example-apps-bk

8d8a62b

refactored kotlin configs and added unit tests

3b3b43f

github-actions Bot removed the CICD Run CI/CD label Jun 8, 2026

jesswrd added the CICD Run CI/CD label Jun 8, 2026

jesswrd added 2 commits June 8, 2026 14:04

Merge branch 'main' into migrate-remaining-example-apps-bk

4941a72

resolved conflicts and formatted file

1a0b640

github-actions Bot removed the CICD Run CI/CD label Jun 8, 2026

jesswrd added the CICD Run CI/CD label Jun 8, 2026

dart format

f7da4f3

github-actions Bot removed the CICD Run CI/CD label Jun 9, 2026

jesswrd added the CICD Run CI/CD label Jun 9, 2026

stuartmorgan-g approved these changes Jun 9, 2026

View reviewed changes

jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2026

auto-submit Bot merged commit bd297cf into flutter:main Jun 9, 2026
87 checks passed

engine-flutter-autoroll mentioned this pull request Jun 9, 2026

Roll Packages from 13b49f41c464 to bd297cf62338 (4 revisions) flutter/flutter#187739

Merged

mdmahendri mentioned this pull request Jun 18, 2026

fix(package_info_plus): support AGP 9 / built-in Kotlin fluttercommunity/plus_plugins#3882

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin#11806

[AGP 9] Migrate Remaining Plugin Example Apps to Built-in Kotlin#11806
auto-submit[bot] merged 7 commits into
flutter:mainfrom
jesswrd:migrate-remaining-example-apps-bk

jesswrd commented May 30, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 2, 2026

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 2, 2026

Uh oh!

Uh oh!

jesswrd commented Jun 2, 2026

Uh oh!

stuartmorgan-g commented Jun 3, 2026

Uh oh!

flutter-dashboard Bot commented Jun 8, 2026

Uh oh!

jesswrd commented Jun 8, 2026

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jesswrd commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jesswrd commented Jun 2, 2026

Uh oh!

stuartmorgan-g commented Jun 3, 2026

Uh oh!

flutter-dashboard Bot commented Jun 8, 2026

Uh oh!

jesswrd commented Jun 8, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jesswrd commented May 30, 2026 •

edited

Loading