[path_provider] Create temp dir in tests if needed#11841
Merged
auto-submit[bot] merged 1 commit intoJun 4, 2026
Merged
Conversation
The integration test step that validates that a file can be created in the returned directory assumes that the directory already exists, which isn't guaranteed to be true for getTemporaryDirectory, and this is now failing on macOS in CI. To avoid the failure, create the directory if necessary for the tests that run on macOS. Fixes flutter/flutter#187563
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests in both path_provider and path_provider_foundation to handle cases where the temporary directory does not exist. It introduces an optional createDirectory parameter to the _verifySampleFile helper function to recursively create the directory when needed, and applies this to the temporary directory tests. There are no review comments, so no feedback is provided.
Collaborator
Author
tamirenkhbayar3-cmd
pushed a commit
to tamirenkhbayar3-cmd/flutter
that referenced
this pull request
Jun 5, 2026
…r#187612) flutter/packages@03352b5...61bdbb4 2026-06-04 stuartmorgan@google.com [tool] Use `flutter` for pub commands when examples use Flutter (flutter/packages#11830) 2026-06-04 stuartmorgan@google.com Sync analysis_options.yaml with flutter/flutter (flutter/packages#11823) 2026-06-04 stuartmorgan@google.com [path_provider] Create temp dir in tests if needed (flutter/packages#11841) 2026-06-04 jeff.ward@datadoghq.com [webview] Add new method for cross plugin webview access (flutter/packages#11714) 2026-06-04 47866232+chunhtai@users.noreply.github.com [ci] Renames the override post-release label for batch release (flutter/packages#11835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
The integration test step that validates that a file can be created in the returned directory assumes that the directory already exists, which isn't guaranteed to be true for getTemporaryDirectory, and this is now failing on macOS in CI. To avoid the failure, create the directory if necessary for the tests that run on macOS. Hopefully fixes flutter/flutter#187563 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…r#187612) flutter/packages@03352b5...61bdbb4 2026-06-04 stuartmorgan@google.com [tool] Use `flutter` for pub commands when examples use Flutter (flutter/packages#11830) 2026-06-04 stuartmorgan@google.com Sync analysis_options.yaml with flutter/flutter (flutter/packages#11823) 2026-06-04 stuartmorgan@google.com [path_provider] Create temp dir in tests if needed (flutter/packages#11841) 2026-06-04 jeff.ward@datadoghq.com [webview] Add new method for cross plugin webview access (flutter/packages#11714) 2026-06-04 47866232+chunhtai@users.noreply.github.com [ci] Renames the override post-release label for batch release (flutter/packages#11835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test step that validates that a file can be created in the returned directory assumes that the directory already exists, which isn't guaranteed to be true for getTemporaryDirectory, and this is now failing on macOS in CI. To avoid the failure, create the directory if necessary for the tests that run on macOS.
Hopefully fixes flutter/flutter#187563
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2