Skip to content

[ci] Renames the override post-release label for batch release#11835

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
chunhtai:rename-override-flag
Jun 4, 2026
Merged

[ci] Renames the override post-release label for batch release#11835
auto-submit[bot] merged 2 commits into
flutter:mainfrom
chunhtai:rename-override-flag

Conversation

@chunhtai

@chunhtai chunhtai commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

The repo check ci will be run when creating release pr against release branch. In that case, we want to ignore the check to guard changes to changelog.md and pubspec.

The solution will be reusing the override: post-release-* label. I decide to also rename the label to override: skip-batch-release-repo-check-* since the original name is not appropriate in this use case.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the VersionAndChangelogValidator to check for the 'override: skip-batch-release-repo-check-' label instead of the 'override: post-release-' label. It also updates the corresponding tests in validate_command_version_test.dart to reflect this label change. There are no review comments, and I have no feedback to provide.

@chunhtai chunhtai requested a review from stuartmorgan-g June 3, 2026 19:33

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2026
@auto-submit

auto-submit Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/11835, because - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 4, 2026
@chunhtai chunhtai added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jun 4, 2026
@auto-submit auto-submit Bot merged commit c584f33 into flutter:main Jun 4, 2026
87 checks passed
tamirenkhbayar3-cmd pushed a commit to tamirenkhbayar3-cmd/flutter that referenced this pull request Jun 5, 2026
…r#187612)

flutter/packages@03352b5...61bdbb4

2026-06-04 stuartmorgan@google.com [tool] Use `flutter` for pub commands
when examples use Flutter (flutter/packages#11830)
2026-06-04 stuartmorgan@google.com Sync analysis_options.yaml with
flutter/flutter (flutter/packages#11823)
2026-06-04 stuartmorgan@google.com [path_provider] Create temp dir in
tests if needed (flutter/packages#11841)
2026-06-04 jeff.ward@datadoghq.com [webview] Add new method for cross
plugin webview access (flutter/packages#11714)
2026-06-04 47866232+chunhtai@users.noreply.github.com [ci] Renames the
override post-release label for batch release (flutter/packages#11835)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…er#11835)

The repo check ci will be run when creating release pr against release branch. In that case, we want to ignore the check to guard changes to changelog.md and pubspec.

The solution will be reusing the `override: post-release-*` label. I decide to also rename the label to `override: skip-batch-release-repo-check-*` since the original name is not appropriate in this use case.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
…r#187612)

flutter/packages@03352b5...61bdbb4

2026-06-04 stuartmorgan@google.com [tool] Use `flutter` for pub commands
when examples use Flutter (flutter/packages#11830)
2026-06-04 stuartmorgan@google.com Sync analysis_options.yaml with
flutter/flutter (flutter/packages#11823)
2026-06-04 stuartmorgan@google.com [path_provider] Create temp dir in
tests if needed (flutter/packages#11841)
2026-06-04 jeff.ward@datadoghq.com [webview] Add new method for cross
plugin webview access (flutter/packages#11714)
2026-06-04 47866232+chunhtai@users.noreply.github.com [ci] Renames the
override post-release label for batch release (flutter/packages#11835)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants