[google_maps_flutter] Add a pinned-SDK web example app#11761
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the google_maps_flutter_web package to address the removal of heatmap support in version 3.65 of the Google Maps JavaScript SDK. Key changes include updating the README with deprecation notices and instructions for pinning the SDK to version 3.64, as well as restructuring the example apps into latest and 3-64 directories. Heatmap integration tests have been moved to the pinned 3-64 example. Review feedback includes corrections for a typo in the documentation, fixing inaccurate comments in the test files, and removing unused dependencies in the new example's configuration.
|
@bparrishMines @tarrinneal If either of you have a chance to review this before @mdebbar please take a look, since it will let us re-open the tree. |
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
1 similar comment
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
…r#187114) flutter/packages@69cf959...fc795e5 2026-05-26 engine-flutter-autoroll@skia.org Roll Flutter from e03b91f to f3a4b98 (63 revisions) (flutter/packages#11789) 2026-05-26 stuartmorgan@google.com [google_maps_flutter] Add Android and iOS attribution ID (flutter/packages#11731) 2026-05-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20251224 to 20260522 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#11776) 2026-05-26 stuartmorgan@google.com [google_maps_flutter] Add a pinned-SDK web example app (flutter/packages#11761) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The tree is currently closed because Google Maps SDK 3.65 came out, and it throws exceptions why trying to use heatmaps, as that functionality has been removed from the SDK. This fixes the tree by creating a second example app for `google_maps_flutter_web` that pins version 3.64 of the Google Maps SDK: - copied the original example - removed all of the non-heatmap tests - consolidated the tests into one file (since it's not clear to me why we had two almost identically-named tests in the firs place, and it was especially confusing with just a few tests) The heatmap tests have been removed from the main example, where they throw. The README has been updated to explain that heatmaps are deprecated, and using them requires pinning 3.64. Fixes flutter/flutter#186946 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…r#187114) flutter/packages@69cf959...fc795e5 2026-05-26 engine-flutter-autoroll@skia.org Roll Flutter from e03b91f to f3a4b98 (63 revisions) (flutter/packages#11789) 2026-05-26 stuartmorgan@google.com [google_maps_flutter] Add Android and iOS attribution ID (flutter/packages#11731) 2026-05-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20251224 to 20260522 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#11776) 2026-05-26 stuartmorgan@google.com [google_maps_flutter] Add a pinned-SDK web example app (flutter/packages#11761) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The tree is currently closed because Google Maps SDK 3.65 came out, and it throws exceptions why trying to use heatmaps, as that functionality has been removed from the SDK.
This fixes the tree by creating a second example app for
google_maps_flutter_webthat pins version 3.64 of the Google Maps SDK:The heatmap tests have been removed from the main example, where they throw.
The README has been updated to explain that heatmaps are deprecated, and using them requires pinning 3.64.
Fixes flutter/flutter#186946
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2