Skip to content

[packages] Tree closed on heatmap removal #186946

Description

@stuartmorgan-g

We have an OOB failure in web tests that is closing the tree:

The test description was:
  changeHeatmaps
═════════════════════════════════════════════════════════════════

end of failure 3


Failure in method: removeHeatmaps
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following NativeError object was thrown running a test:
  Error: The Heatmap Layer functionality in the Maps JavaScript
API is no longer available in the Maps JavaScript API as of
version 3.65. For more info, see
https://developers.google.com/maps/deprecations.

When the exception was thrown, this was the stack:
https://maps.googleapis.com/maps/api/js 157:423                                   new HeatmapLayer
package:google_maps_flutter_web/src/heatmaps.dart 30:37                           [_addHeatmap]
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 118:77  tear
dart-sdk/lib/collection/set.dart 143:29                                           forEach
package:google_maps_flutter_web/src/heatmaps.dart 24:18                           addHeatmaps
[...]

Immediate term, we need to disable any tests on web that attempt to use heatmaps. Short term, we need to decide what to do about this for the plugin as a whole:

  • We should at least document this at the app-facing doc level and in the implementation package README
  • We should consider doing an implementation-level breaking change to remove the heatmap code. I don't think that needs to be an app-level breaking change since it already throws on usage due to the SDK-level change. I need to look into whether or not clients can pin a version of the SDK that still supports heatmaps though before going that route.

Metadata

Metadata

Labels

P1High-priority issues at the top of the work listfyi-webFor the attention of Web platform teamp: mapsGoogle Maps pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions