Skip to content

[shared_preferences] Switch to Kotlin Pigeon#11661

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:kotlin-pigeon-shared-prefs
Jun 10, 2026
Merged

[shared_preferences] Switch to Kotlin Pigeon#11661
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:kotlin-pigeon-shared-prefs

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and updates API signatures and number handling for Kotlin/Java generator differences.

Part of flutter/flutter#158287

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and
updates API signatures and number handling for Kotlin/Java generator
differences.

Part of flutter/flutter#158287

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the internal implementation of the shared_preferences_android package from Java-generated Pigeon code to Kotlin-generated Pigeon code. The LegacySharedPreferencesPlugin has been updated to use primitive types and the new Kotlin companion setup methods. Additionally, the pigeon dependency is bumped to version 26.3.4, and autogenerated files in Dart and Kotlin are updated with improved equality, hashing, and error-handling utilities. I have no feedback to provide.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 3, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 10, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 10, 2026
@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jun 10, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2026
@auto-submit

auto-submit Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/11661, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 10, 2026
@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jun 10, 2026
@auto-submit auto-submit Bot merged commit 1b56cde into flutter:main Jun 10, 2026
87 checks passed
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and updates API signatures and number handling for Kotlin/Java generator differences.

Part of flutter/flutter#158287

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
pull Bot pushed a commit to Spencerx/flutter that referenced this pull request Jun 11, 2026
…r#187784)

flutter/packages@bd297cf...1b56cde

2026-06-10 stuartmorgan@google.com [shared_preferences] Switch to Kotlin
Pigeon (flutter/packages#11661)
2026-06-10 tarrinneal@gmail.com [pigeon] updates toString and isNullish
methods (flutter/packages#11625)
2026-06-10 stuartmorgan@google.com [various] Remove moved packages
(flutter/packages#11850)
2026-06-10 engine-flutter-autoroll@skia.org Roll Flutter from
1bdf4af to 66aaa9a (30 revisions) (flutter/packages#11876)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
…r#187784)

flutter/packages@bd297cf...1b56cde

2026-06-10 stuartmorgan@google.com [shared_preferences] Switch to Kotlin
Pigeon (flutter/packages#11661)
2026-06-10 tarrinneal@gmail.com [pigeon] updates toString and isNullish
methods (flutter/packages#11625)
2026-06-10 stuartmorgan@google.com [various] Remove moved packages
(flutter/packages#11850)
2026-06-10 engine-flutter-autoroll@skia.org Roll Flutter from
1bdf4af to 66aaa9a (30 revisions) (flutter/packages#11876)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: shared_preferences platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants