Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity #9036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivity in FlutterActivity
collinjackson
added a commit
to collinjackson/engine
that referenced
this pull request
Mar 27, 2017
FragmentActivity is required for plugins that use auto managed Google APIs, such as Google Sign-In. Requires flutter/flutter#9036 to land so that gradle builds include FragmentActivity.
Contributor
|
|
collinjackson
added a commit
to collinjackson/engine
that referenced
this pull request
Mar 27, 2017
FragmentActivity is required for plugins that use auto managed Google APIs, such as Google Sign-In. Requires flutter/flutter#9036 to land so that gradle builds include FragmentActivity.
collinjackson
added a commit
to collinjackson/engine
that referenced
this pull request
Mar 27, 2017
FragmentActivity is required for plugins that use auto managed Google APIs, such as Google Sign-In. Requires flutter/flutter#9036 to land so that gradle builds include FragmentActivity.
collinjackson
added a commit
to collinjackson/engine
that referenced
this pull request
Mar 27, 2017
FragmentActivity is required for plugins that use auto managed Google APIs, such as Google Sign-In. Requires flutter/flutter#9036 to land so that gradle builds include FragmentActivity.
collinjackson
added a commit
to flutter/engine
that referenced
this pull request
Mar 27, 2017
FragmentActivity is required for plugins that use auto managed Google APIs, such as Google Sign-In. Requires flutter/flutter#9036 to land so that gradle builds include FragmentActivity.
Contributor
|
FYI, with this change the |
Contributor
Author
|
I'll try rolling it back |
collinjackson
added a commit
to collinjackson/flutter
that referenced
this pull request
Mar 28, 2017
…gmentActivity in FlutterActivity (flutter#9036)" This reverts commit 6bf0ceb.
collinjackson
added a commit
to collinjackson/flutter
that referenced
this pull request
Mar 28, 2017
…e of FragmentActivity in FlutterActivity (flutter#9036)"" Increased the time limit slightly to allow the microbenchmark test time to finish.
collinjackson
added a commit
to collinjackson/flutter
that referenced
this pull request
Mar 28, 2017
…allow use of FragmentActivity in FlutterActivity (flutter#9036)"" (flutter#9046)" Test is still failing with increased timeout. This reverts commit 864b3c3.
collinjackson
added a commit
that referenced
this pull request
Mar 28, 2017
collinjackson
added a commit
to collinjackson/flutter
that referenced
this pull request
Mar 28, 2017
This reverts commit e2b49d6.
collinjackson
added a commit
that referenced
this pull request
Mar 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to land #3529, on the path to fixing #8581