Skip to content

Re-land support for fragment libraries so we can see if microbenchmarks pass #9068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
collinjackson merged 1 commit into from
Mar 29, 2017
Merged

Re-land support for fragment libraries so we can see if microbenchmarks pass #9068

collinjackson merged 1 commit into from
Mar 29, 2017

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Mar 28, 2017

This reverts commit e2b49d6.

@collinjackson
Re-land flutter#9036
ae78fbf 
This reverts commit e2b49d6.
@collinjackson collinjackson requested a review from yjbanov March 28, 2017 23:29
@collinjackson collinjackson changed the title Re-land #9036 so we can see if tests pass Re-land support for fragment libraries so we can see if microbenchmarks pass Mar 28, 2017
@collinjackson collinjackson merged commit 8f9d4a2 into flutter:master Mar 29, 2017
@collinjackson collinjackson deleted the retry_9036 branch March 29, 2017 00:05
@Hixie
Copy link
Contributor

Hixie commented Mar 29, 2017

This resulted in a notable increase to the size of the basic material app binary.

@collinjackson
Copy link
Contributor Author

collinjackson commented Mar 29, 2017 •
edited
Loading

My understanding is that our current internal customers are all using the Android support libraries because they are required for Google login, and probably a lot of our external customers will want to use Google API auto-management in their app, or inherit from FragmentActivity for some reason.

There's not an easy way to have FlutterActivity extend FragmentActivity on some apps and Activity on others, but I guess we could provide a FlutterFragmentActivity if we really wanted to punt this choice to the developers and give them the option to shave 500kb off their APK size.

I think we should re-baseline the benchmark, but I'm open to feedback / other approaches.

/cc @abarth

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@collinjackson @Hixie @googlebot