Skip to content

Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSur… #87233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkwingsmt merged 1 commit into from
Jul 28, 2021
Merged

Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSur… #87233

dkwingsmt merged 1 commit into from
Jul 28, 2021

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jul 28, 2021

…faceSize and live tests (#86912)"

This reverts commit b50991d.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 28, 2021
@google-cla google-cla bot added the cla: yes label Jul 28, 2021
flar
flar approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar
Copy link
Contributor

flar commented Jul 28, 2021

Before this lands, if we can get #87226 in and it restores the performance metrics then this revert may be unnecessary. Since the original commit used setSurfaceSize and since that method was side effecting other tests, it is possible (though we haven't verified this) that the problem may simply be that the change in question was using the mechanism that was broken.

The PR above fixes the side effect of the method, so if that fixes the benchmarks then this revert may not be needed. We won't know until that PR lands and the benchmarks run, though.

@dkwingsmt
Copy link
Contributor Author

dkwingsmt commented Jul 28, 2021 •
edited
Loading

@flar I don't think #87226 fixes the performance since I don't find many tests change the surface size anyway, and the surface size should have been reset as the application starts up. It's a good change though.

@dkwingsmt dkwingsmt merged commit 5b80d32 into flutter:master Jul 28, 2021
@dkwingsmt dkwingsmt deleted the revert-reland-2-set-surface-size-test-messages branch July 28, 2021 22:44
dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Jul 29, 2021
@dkwingsmt
Revert "Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work wit…
202522c 
…h setSurfaceSize and live tests (flutter#86912)" (flutter#87233)"

This reverts commit 5b80d32.
dkwingsmt added a commit that referenced this pull request Jul 29, 2021
@dkwingsmt
Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize…
884158a 
… and live tests (#87239)

* Revert "Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86912)" (#87233)"

This reverts commit 5b80d32.

* Record tap positions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flar flar flar approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @flar