Skip to content

Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #87239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkwingsmt merged 2 commits into from
Jul 29, 2021
Merged

Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #87239

dkwingsmt merged 2 commits into from
Jul 29, 2021
+247 −72

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jul 29, 2021 •
edited
Loading

Reland #86449

On top of the 2nd reland (#86912), this PR records the tap positions to ensure exact match. This is not due to the revert, but only an improvement I've wanted to make.

The 2nd reland was reverted because we were unsure whether the benchmark regression should be treated as intended. Through discussion we've agreed to accept the benchmark changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 29, 2021
@google-cla google-cla bot added the cla: yes label Jul 29, 2021
@dkwingsmt dkwingsmt requested a review from goderbauer July 29, 2021 04:55
goderbauer
goderbauer approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt merged commit 884158a into flutter:master Jul 29, 2021
@dkwingsmt dkwingsmt deleted the reland-3-set-surface-size-test-messages branch July 29, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @goderbauer