Skip to content

Clean up the bindings APIs #86388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Jul 14, 2021
Merged

Clean up the bindings APIs #86388

fluttergithubbot merged 4 commits into from
Jul 14, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 13, 2021

  • Add more documentation.
  • Make premature binding accesses have better runtime errors.
  • Make accesses to instance not required !.
  • Rationalize our "ensureInitialized" etc logic.

Fixes #64830.

This is identical to #83843 (which was reverted in #86386) except that it removes a bogus assert in the driver tests that I had missed because it turns out we don't run any driver tests pre-commit. Oops.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hixie added 4 commits July 13, 2021 16:04
@Hixie
Clean up the bindings APIs.
a71cc6b 
* Add more documentation.
* Make premature binding accesses have better runtime errors.
* Make accesses to `instance` not required `!`.
* Rationalize our "ensureInitialized" etc logic.
@Hixie
dart fix --apply
dd0b457
@Hixie
Review comments
ebcd359
@Hixie
Remove now-bogus assert from Driver code
c1b320a
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 13, 2021
@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Jul 13, 2021

cc @goderbauer for review

goderbauer
goderbauer approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor Author

Hixie commented Jul 13, 2021

Gardeners: In case this causes any devicelab failures, please do not hesitate to revert it. Thanks!

@fluttergithubbot fluttergithubbot merged commit 31de052 into flutter:master Jul 14, 2021
zanderso added a commit that referenced this pull request Jul 14, 2021
@zanderso
Revert "Clean up the bindings APIs (#86388)"
e4a5a15 
This reverts commit 31de052.
@zanderso zanderso mentioned this pull request Jul 14, 2021
Merged
zanderso added a commit that referenced this pull request Jul 14, 2021
@zanderso
Revert "Clean up the bindings APIs (#86388)" (#86404)
7f741e9 
This reverts commit 31de052.
@Hixie Hixie deleted the binding3 branch July 14, 2021 18:31
@Hixie Hixie mentioned this pull request Jul 14, 2021
Merged
8 tasks
@Hixie Hixie mentioned this pull request Oct 8, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this pull request Feb 3, 2022
@Hixie
Clean up the bindings APIs.
5910971 
* Add more documentation.
* Make premature binding accesses have better runtime errors.
* Make accesses to `instance` not required `!`.
* Rationalize our "ensureInitialized" etc logic.

Fixes flutter#64830.

Most of these changes were done using `dart fix --apply`, but they have been squashed into one commit for easier merging.
To see previous reviews of this PR, see
flutter#83843,
flutter#86388,
flutter#86438, and
flutter#89451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up Binding.instance

3 participants

@Hixie @goderbauer @fluttergithubbot