fix unsorted directives #81210
Merged
fix unsorted directives #81210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 27, 2021
This is a reland of 17644ee Additional supporting changes in flutter (and plugins): flutter/flutter#81017 flutter/plugins#3823 flutter/flutter#80817 flutter/flutter#80901 flutter/flutter#81210 Additional context in meta linter issue: https://github.com/dart-lang/linter/issues/2609 Original change's description: > linter 1.4.0 > > Mitigating PRs: > > https://dart-review.googlesource.com/c/sdk/+/196223 > https://dart-review.googlesource.com/c/sdk/+/196180 > > flutter/flutter#80817 > flutter/flutter#80901 > > > > > > Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026 > Commit-Queue: Phil Quitslund <pquitslund@google.com> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Change-Id: Ie6b9682a2f54ef039dd7ac9c6a46cb925615acef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196581 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming linter release includes a fix to sort_directives that will trigger a host of new violations. This fixes issues that cropped up since #80901.
List which issues are fixed by this PR. You must list at least one issue.
dart-lang/sdk#58380
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.