fix sort_directives violations #80817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gold has detected about 1 untriaged digest(s) on patchset 1. |
Contributor
|
Looks like there were several places where the imports were sorted about the language version comment: |
Contributor
Author
|
Ah. Not good. Thanks for the catch @jonahwilliams. I'll tidy up. Thanks! |
Contributor
Author
|
Sorry for the haste. I should have run |
|
Gold has detected about 1 untriaged digest(s) on patchset 4. |
goderbauer
reviewed
Apr 20, 2021
Member
goderbauer
left a comment
There was a problem hiding this comment.
The golden file change is ... unexpected. Maybe it needs to be rebased to latest master?
dev/benchmarks/complex_layout/test/measure_scroll_smoothness.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/commands.shard/permeable/analyze_once_test.dart
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/ios/ios_device_start_nonprebuilt_test.dart
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/resident_devtools_handler_test.dart
Show resolved
Hide resolved
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
# Conflicts: # packages/flutter_tools/test/general.shard/bundle_shim_test.dart
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 22, 2021
Mitigating PRs: https://dart-review.googlesource.com/c/sdk/+/196223 https://dart-review.googlesource.com/c/sdk/+/196180 flutter/flutter#80817 flutter/flutter#80901 Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 23, 2021
This reverts commit 17644ee. Reason for revert: This caused various failures in HHH configuration which is an early warning that dart-lang/sdk -> flutter/{engine,flutter} rolls will not work smoothly. See more information in go/dartvm-gardening-log for various failures this causes. Original change's description: > linter 1.4.0 > > Mitigating PRs: > > https://dart-review.googlesource.com/c/sdk/+/196223 > https://dart-review.googlesource.com/c/sdk/+/196180 > > flutter/flutter#80817 > flutter/flutter#80901 > > > > > > Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026 > Commit-Queue: Phil Quitslund <pquitslund@google.com> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> TBR=brianwilkerson@google.com,pquitslund@google.com,davidmorgan@google.com Change-Id: I15af9de53d98de7b65902a015bef7ac2d368abeb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196499 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
9 tasks
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 27, 2021
This is a reland of 17644ee Additional supporting changes in flutter (and plugins): flutter/flutter#81017 flutter/plugins#3823 flutter/flutter#80817 flutter/flutter#80901 flutter/flutter#81210 Additional context in meta linter issue: https://github.com/dart-lang/linter/issues/2609 Original change's description: > linter 1.4.0 > > Mitigating PRs: > > https://dart-review.googlesource.com/c/sdk/+/196223 > https://dart-review.googlesource.com/c/sdk/+/196180 > > flutter/flutter#80817 > flutter/flutter#80901 > > > > > > Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026 > Commit-Queue: Phil Quitslund <pquitslund@google.com> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Change-Id: Ie6b9682a2f54ef039dd7ac9c6a46cb925615acef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196581 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming linter release includes a fix to
sort_directivesthat will trigger a host of new violations. This fixes them up.See: https://dart-review.googlesource.com/c/sdk/+/196026
Relevant failures: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8849409225986491904/+/steps/analyze_flutter_flutter/0/stdout
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.