Skip to content

[flutter_releases] Flutter Stable 1.22.6 Framework Cherrypicks#74355

Merged
christopherfujino merged 3 commits into
flutter:flutter-1.22-candidate.12from
chris-forks:flutter-1.22-candidate.12
Jan 22, 2021
Merged

[flutter_releases] Flutter Stable 1.22.6 Framework Cherrypicks#74355
christopherfujino merged 3 commits into
flutter:flutter-1.22-candidate.12from
chris-forks:flutter-1.22-candidate.12

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Jan 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@flutter-dashboard

flutter-dashboard Bot commented Jan 20, 2021

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 20, 2021
@google-cla google-cla Bot added the cla: yes label Jan 20, 2021
@christopherfujino christopherfujino removed the request for review from jmagman January 20, 2021 21:28
@jmagman

jmagman commented Jan 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Tested:

  1. Checked out master
  2. Created a project
  3. flutter build ios succeeds
  4. ios/Flutter/Flutter.podspec contains s.vendored_frameworks = 'path/to/nothing'
  5. Checked out stable
  6. flutter build ios fails -> fatal error: 'Flutter/Flutter.h' file not found
  7. flutter clean
  8. flutter build ios fails -> fatal error: 'Flutter/Flutter.h' file not found

Checked out this PR

  1. flutter build ios fails -> fatal error: 'Flutter/Flutter.h' file not found
  2. flutter clean
  3. flutter build ios succeeds

jmagman
jmagman approved these changes Jan 20, 2021
View reviewed changes

@jmagman jmagman left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
See #72306 and #70895

@flutter-dashboard flutter-dashboard Bot added the engine flutter/engine related. See also e: labels. label Jan 22, 2021
@christopherfujino christopherfujino merged commit 9b2d32b into flutter:flutter-1.22-candidate.12 Jan 22, 2021
@christopherfujino christopherfujino deleted the flutter-1.22-candidate.12 branch January 22, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes
+1 more reviewer
@pcsosinski pcsosinski pcsosinski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christopherfujino @jmagman @pcsosinski