Do not add CI build settings to macOS#71860
Merged
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
godofredoc
approved these changes
Dec 7, 2020
yusufm
approved these changes
Dec 7, 2020
This was referenced Dec 7, 2020
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Jan 20, 2021
christopherfujino
added a commit
that referenced
this pull request
Jan 22, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#43553 added the ability to set Xcode build settings from environment variables so the devicelab could set up provisioning profiles. Using the same settings for iOS and macOS is causing macOS builds to fail. We think it is related to newer versions of CocoaPods incorrectly signing frameworks? (only executables like apps or extensions should be signed).
Related Issues
Workaround #71613