Skip to content

[flutter_releases] Flutter Framework Stable 1.22.5 cherrypicks#72079

Merged
christopherfujino merged 1 commit into
flutter:flutter-1.22-candidate.12from
chris-forks:cherrypicks-flutter-1.22-candidate.12
Dec 10, 2020
Merged

[flutter_releases] Flutter Framework Stable 1.22.5 cherrypicks#72079
christopherfujino merged 1 commit into
flutter:flutter-1.22-candidate.12from
chris-forks:cherrypicks-flutter-1.22-candidate.12

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Dec 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

No framework changes, picking up engine revert flutter-team-archive/engine#22974

CI Failures are the same as previous build

Post-submit, we hit #71613. It was ignored, to fix would require cherrypicking #71860

@flutter-dashboard flutter-dashboard Bot changed the base branch from flutter-1.22-candidate.12 to master December 10, 2020 18:38
@flutter-dashboard

flutter-dashboard Bot commented Dec 10, 2020

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@google-cla google-cla Bot added the cla: yes label Dec 10, 2020
@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 10, 2020
@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 December 10, 2020 19:01
pcsosinski
pcsosinski approved these changes Dec 10, 2020
View reviewed changes

@pcsosinski pcsosinski left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

@christopherfujino christopherfujino merged commit 7891006 into flutter:flutter-1.22-candidate.12 Dec 10, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch December 10, 2020 19:54
@braddillman braddillman mentioned this pull request Jan 18, 2021
Closed
@christopherfujino christopherfujino mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@pcsosinski pcsosinski pcsosinski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @pcsosinski