Skip to content

Reenable module_test_ios UI tests #72145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Dec 11, 2020
Merged

Reenable module_test_ios UI tests #72145

jmagman merged 1 commit into from
Dec 11, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 11, 2020 •
edited
Loading

Description

Fix module_test_ios UI tests.

Related Issues

Fixes #70630
Xcode was updated in https://github.com/flutter/infra/pull/294.
#71730
#70881

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically labels Dec 11, 2020
@jmagman jmagman self-assigned this Dec 11, 2020
@google-cla google-cla bot added the cla: yes label Dec 11, 2020
@jmagman
Copy link
Member Author

jmagman commented Dec 11, 2020

It passed:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8861183581427708480/+/steps/run_module_test_ios/0/stdout

@jmagman jmagman requested a review from dnfield December 11, 2020 19:48
@jmagman jmagman merged commit f123f64 into flutter:master Dec 11, 2020
@jmagman jmagman deleted the module-ui-tests branch December 11, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

testFlutterViewWarm flake

2 participants

@jmagman @dnfield